Giter Club home page Giter Club logo

october_envbar's People

Contributors

jan-vince avatar magenizr avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

october_envbar's Issues

Issue on logout

I have this issue sometime when i logout :

Call to a member function isSuperUser() on null
~/plugins/magenizr/envbar/models/Settings.php line 145

With this quick fix it's OK

   private function checkPermissions()
    {
        if (!$this->enabled) {
            return false;
        }

        if ($this->superuser) {
            $backendUser = BackendAuth::getUser();
            if ($backendUser) {
                if (!$backendUser->isSuperUser) {
                    return false;
                }
            }
        }

        if (!$this->getEnv()) {
            return false;
        }

        return true;
    }

Check env on every pageload.

If I temporarily change env on my local system just to check if the colors change, they don't.
I have to disable and enable to see the color change everytime I change the environment.

Maybe the plugin checks the env only on certain events instead of on every page load.

White listed folder?

After install I get 404 for file /storage/temp/magenizr.envbar.style.css?1.0.1.

When I put /storage/temp folder in .htaccess, it works:

RewriteCond %{REQUEST_FILENAME} !/storage/temp/.*

Maybe move the file to /storage/temp/public folder which is allowed by default in OctoberCMS .htaccess file?

Or maybe I am missing something?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.