Giter Club home page Giter Club logo

Comments (5)

callumlocke avatar callumlocke commented on August 21, 2024

I worked out I need to listen for the finish event on the tar.extract() part instead:

fs.createReadStream('./my-file.tar')
  .pipe(
    tar.extract('./my-dir')
      .on('finish', function () {
        console.log('DONE!');
      })
  )
  .on('error', function (err) {
    console.error('ERROR', err);
  })
  .on('end', function () {
    console.log('THIS NEVER FIRES');
  });

The original stream's end event is never fired. I'm guessing this is because there are extra bytes at the end of the tar that tar.extract doesn't need to read, so it just stops listening for its data events? Don't know if this is a bug. Please close this if not.

from tar-fs.

mafintosh avatar mafintosh commented on August 21, 2024

The extract stream does not emit finish since it's a writable stream. The pack stream emits end though (since its readable)

from tar-fs.

callumlocke avatar callumlocke commented on August 21, 2024

The extract stream does not emit finish since it's a writable stream.

? but finish does fire, in my example

from tar-fs.

mafintosh avatar mafintosh commented on August 21, 2024

doh. I meant:

The extract stream does not emit end since it's a writable stream. The pack stream emits end though (since its readable)

from tar-fs.

callumlocke avatar callumlocke commented on August 21, 2024

ah cool :) so this is right then

from tar-fs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.