Comments (4)
CodeMan99
commented on August 21, 2024
Investigating further it seems there is a mismatch between the test expectations and the intention of the code.
The packing code always respects umask even if the mode is valid. This means that when the original file has umask permissions set, the above test case will fail.
from tar-fs.
CodeMan99
commented on August 21, 2024
One option for working around this issue is #87 and the following patch.
diff --git a/test/index.js b/test/index.js
index 3f5e07bb2af2..83b42d34cf18 100644
--- a/test/index.js
+++ b/test/index.js
@@ -20,7 +20,7 @@ test('copy a -> copy/a', function (t) {
rimraf.sync(b)
tar.pack(a)
- .pipe(tar.extract(b))
+ .pipe(tar.extract(b, { umask: 0 }))
.on('finish', function () {
var files = fs.readdirSync(b)
t.same(files.length, 1)
@@ -41,7 +41,7 @@ test('copy b -> copy/b', function (t) {
rimraf.sync(b)
tar.pack(a)
- .pipe(tar.extract(b))
+ .pipe(tar.extract(b, { umask: 0 }))
.on('finish', function () {
var files = fs.readdirSync(b)
t.same(files.length, 1)from tar-fs.
mafintosh
commented on August 21, 2024
Wanna send a PR?
from tar-fs.
CodeMan99
commented on August 21, 2024
Wanna send a PR?
See #87
from tar-fs.
Related Issues (20)
- problem with pack if the file is bigger than 8G HOT 3
- Tar file is corrupted when using single File larger than 8 GB HOT 5
- PaxHeader HOT 1
- High memory consumption on AWS Lambda Node16 or higher HOT 3
- some .bin file can not be packed in tar(windows system) HOT 2
- some .bin file can not be packed in tar(windows system) HOT 1
- Preserve file UID/GID when creating an archive HOT 1
- pack ignore function called with header HOT 1
- Make opts.dereference available in extract() too HOT 1
- Can't use zlib.createGzip as transform in mapStream function HOT 4
- Cannot unpack read-only dirs HOT 4
- emoji inside of files breaks the resulting tar. HOT 1
- Add option to ignore missing files/stat errors HOT 5
- Consider dropping mkdirp HOT 4
- Question on unpacking the archive HOT 1
- npm pulls in different versions of tar-stream HOT 4
- SUID bits not working when extracting files for different users HOT 1
- Improve sorting for better compression HOT 5
- tar-fs is 2.5x slower than node-tar at decompressing? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tar-fs.