maestrano / impac-angular Goto Github PK

The Utilities service is not namespace and interfering with the host application:

angular.module('impac.services.utilities', []).service('Utilities', function() {})

You can also improve the message with:

-- capitalizedAttr = attribute.charAt(0).toUpperCase() + attribute.slice(1)
++ capitalizedAttr = (attribute.charAt(0).toUpperCase() + attribute.slice(1)).replace('_', ' ')

To avoid stuff like Current_password

TypeError: Cannot read property 'account_name' of undefined
    at sort (impac-angular.js:7333)
    at Object.w.groupAccounts (impac-angular.js:7361)
    at Object.$scope.multiCompanyComparisonOnChange [as onChangeCallback] (impac-angular.js:3149)
    at impac-angular.js:3135
    at arrayEach (lodash.js:1289)
    at Function.<anonymous> (lodash.js:3345)
    at Object.$scope.callbacks.runMultiCompanyComparison (impac-angular.js:3134)
    at initializeComparisonMode (impac-angular.js:7371)
    at Object.setting.initialize (impac-angular.js:7392)
    at impac-angular.js:2321

Line 7333 is matcher = normalise(baseAccount[groupByKey]);

Probably has something to do with the id="widget-section" block in dashboard.tmpl

referenced by @Picsou372

Hi there,

Currently, PwC is planning to have Chinese support for PwC-Enterprise project, but I found that it is a bit hard to do as many texts are hard coded in impac-angular directives.

So I just want to raise this issue and see how we can add i18n support for impac-angular.

Thanks

Leo Liang

This is in Cake Factory organisation of John Doe.

On first load, charts are not supposed to be animated. However, Accounts class comparison seems to be displayed with an animation, which is not completing (a widget refresh is needed to display the full chart)

When I open my dashboard page, server return 401 response. But impac-angular output unrelated error message in the console:

ImpacKpisSvc - cannot retrieve kpis templates list

Maybe ImpacKpisSvc should only catch missing kpis templates error

As stupid as it sounds, I actually think this would be useful :)

A simple notes widget with several tabs to record ToDos and other useful information.

Instead of completely clearing the accounts list, we should keep in the list the accounts that have previously been selected, and that match the new criteria.

Example:

Given that I have only "CompanyA" enabled, and I have selected "Account1" and "Account2",
When I enable "CompanyB"
Then it should keep "CompanyA - Account1" and "CompanyA - Account2" in the selection list

Other example:

Given that I have "CompanyA" and "CompanyB" selected, in "compare matching accounts" mode, with "Account1" selected
When I untick the checkbox,
Then it should keep "CompanyA - Account1" and "CompanyB - Account1" in the selection list

See the idea @xaun ?

Problem tied to chartjs. May have something to do with chartjs/Chart.js#1622