madscheme / fastapi Goto Github PK

View Code? Open in Web Editor NEW

73.0 73.0 19.0 118 KB

Companion for the O'Reilly book "FastAPI: Modern Python Web Development"

Python 96.17% Shell 0.60% HTML 3.23%

fastapi's People

Contributors

Stargazers

Watchers

Forkers

pleopardi sd2017 shyxin a-coello hedm0423 ecrespo khalil00028 tuapsekad caribay ojieh94 nhatsangvn igorank zamir5895 isribalaji xyvs

fastapi's Issues

name passed as parameter but not used

https://github.com/madscheme/fastapi/blob/fd72f0266454602a1e044516d014f093591f3e7f/data/init.py#L11C1-L18C42

name is an optional parameter but its value is set from an environment variable before it is read.

Unused imports

fastapi/data/creature.py

Lines 1 to 4 in fd72f02

 from copy import copy 

 from .init import (conn, curs, get_db, IntegrityError) 

 from model.creature import Creature 

 from error import Missing, Duplicate

creature.py:1:18: F401 [*] `copy.copy` imported but unused
creature.py:2:20: F401 [*] `.init.conn` imported but unused
creature.py:2:32: F401 [*] `.init.get_db` imported but unused

Unused import

fastapi/data/explorer.py

Line 1 in fd72f02

from .init import (conn, curs, IntegrityError)

explorer.py:1:20: F401 [*] `.init.conn` imported but unused

Useless os.getenv

fastapi/data/init.py

Lines 19 to 24 in fd72f02

 if not name: 

 top_dir = Path(__file__).resolve().parents[1] # repo top 

 db_dir = top_dir / "db" 

 db_name = "cryptid.db" 

 db_path = str(db_dir / db_name) 

 name = os.getenv("CRYPTID_SQLITE_DB", db_path)

On line 24, os.getenv is called to get an environment variable value or to default to calculated name. But the call is made in a scope where it is known that the os.getenv call will return None, so the use of name is certain.

May as well change the code to use name directly without calling os.getenv.

fetchall / fetchone

fastapi/data/game.py

Lines 6 to 10 in fd72f02

 curs.execute(qry) 

 rows = curs.fetchall() 

 if rows: 

 print(f"{rows=}") 

 name = rows[0][0]

If this is supposed to work with only one row, may as well call fetchone instead of fetchall.

Unused imports

fastapi/data/init.py

Lines 5 to 6 in fd72f02

 from sqlite3 import connect, IntegrityError, Connection, Cursor 

 from error import Missing, Duplicate

init.py:5:30: F401 [*] `sqlite3.IntegrityError` imported but unused
init.py:6:19: F401 [*] `error.Missing` imported but unused
init.py:6:28: F401 [*] `error.Duplicate` imported but unused

madscheme / fastapi Goto Github PK

fastapi's People

Contributors

Stargazers

Watchers

Forkers

fastapi's Issues

name passed as parameter but not used

Unused imports

Unused import

Useless os.getenv

fetchall / fetchone

Unused imports

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	from copy import copy
	from .init import (conn, curs, get_db, IntegrityError)
	from model.creature import Creature
	from error import Missing, Duplicate

	if not name:
	top_dir = Path(__file__).resolve().parents[1] # repo top
	db_dir = top_dir / "db"
	db_name = "cryptid.db"
	db_path = str(db_dir / db_name)
	name = os.getenv("CRYPTID_SQLITE_DB", db_path)

	curs.execute(qry)
	rows = curs.fetchall()
	if rows:
	print(f"{rows=}")
	name = rows[0][0]

	from sqlite3 import connect, IntegrityError, Connection, Cursor
	from error import Missing, Duplicate