madleech / arduinocmri Goto Github PK

I have migrated to the Arduino Web editor.
Research has shown that a "properties" file has to be included.
Can you help?

I'm not 100% sure if this is a bug or if it's just me doing something wrong, but I can only get bit 0 to work. I've got some if statements that deal with the results, and one works and the others don't.

Is there perhaps a better documented example of many outputs? The comments in the example there now are a little lacking.

I have spent the day fiddling with your library trying to see if I could get it to port over into the Energia "Arduino Fork IDE". I was not having any success. I as well has many others who play with the MSP430's would get a lot of play out of this. I'm will to help with testing on the MSP430 platform.

"void CMRI::transmit()
{
delay(50); // tiny delay to let things recover"

50 milliseconds is not a tiny delay, and it prevents things like servos from working well. Was this meant to be "delayMicroseconds(50)" or can it be changed to a non-blocking delay?

Hi Michael

At lines https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L107, https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L115, https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L130, test should be >= to prevent out of bound access of the array.

Best regards

Whenever I close a JMRI turnout that's assigned to a CMRI bit, the console gives an error like these:

2016-07-07 16:21:27,084 jmrix.AbstractMRTrafficController     ERROR - reply complete in unexpected state: 10 was 41 52 00 00 00 [Receive]
2016-07-07 16:21:27,089 jmrix.AbstractMRTrafficController     ERROR - reply complete in unexpected state: 10 was 41 52 00 00 00 [Receive]
2016-07-07 16:21:33,494 jmrix.AbstractMRTrafficController     ERROR - reply complete in unexpected state: 15 was 41 52 00 00 00 [Receive]
2016-07-07 16:21:33,498 jmrix.AbstractMRTrafficController     ERROR - reply complete in unexpected state: 15 was 41 52 00 00 00 [Receive]
2016-07-07 16:21:33,554 jmrix.AbstractMRTrafficController     ERROR - reply complete in unexpected state: 15 was 41 52 00 00 00 [Receive]

I've also run into some issues where the Arduino seems to be "imagining" bits. It will act on some random bit being set even if I don't have that bit set up to do anything in JMRI. I may be posting this in the wrong place; it very well could be a bug with JMRI, but I wanted to check here first.

Thanks for your patience. I know I've posted a ton of issues, so I appreciate your help.

When I compile my program, I get this warning message:

/home/hampton/Arduino/libraries/CMRI/CMRI.cpp: In member function 'uint8_t CMRI::_decode(uint8_t)':
/home/hampton/Arduino/libraries/CMRI/CMRI.cpp:240:9: warning: converting to non-pointer type 'uint8_t {aka unsigned char}' from NULL [-Wconversion-null]
  return NULL;
         ^
/home/hampton/Arduino/libraries/CMRI/CMRI.cpp:252:10: warning: converting to non-pointer type 'uint8_t {aka unsigned char}' from NULL [-Wconversion-null]
   return NULL;
          ^

I'm not experienced enough to know what this means, or if I should even worry about it, but I've never seen this error before when using this library.

Despite what the README and function documentation in the cpp source file says the process function simply returns a bool, true for "poll" or "set" otherwise false. That's a shame as I have an application where if no "poll" is processed I'd like to trigger a transmit to cause an immediate update.

I know the README says the Uno won't work because JMRI leaves both DTR and RTS off. However, in a conversation with the JMRI developers, I have been informed this is not the case. Does this mean the Uno should work? Perhaps you should update your README...

Conversation I had with JMRI devs

Hi, I've wired up the circuit described on your website using a single USB RS485 transciever and an Arduino Nano with a MAX485 on a breadboard. For some reason I cannot get anything to happen. The Arduino stays in RX mode constantly according to the LEDs, so not sure why it's doing that.