Comments (4)
madeleineostoja
commented on June 1, 2024
There's a discussion going at madeleineostoja/rucksack#31 about this. Not sure if it falls within responsive-font-sizes purview, especially since line-height can already be a unitless value, and it would have to parse line-height values separately. Might be better suited to an accompanying responsive-line-height plugin.
from postcss-responsive-type.
perrin4869
commented on June 1, 2024
Well, this repo is called responsive-type, and line-height is part of type, so I think it belongs here conceptually. Also, a lot of the implementation details are similar, so practically speaking sharing the same codebase will make things cleaner.
I'll work on the pull request in a little bit, maybe also throw in a bit of documentation for the supported unit combinations as well. Thanks!
from postcss-responsive-type.
madeleineostoja
commented on June 1, 2024
Yep that's fair. Definitely open to a pull request.
from postcss-responsive-type.
perrin4869
commented on June 1, 2024
Cool, you can close this now :)
from postcss-responsive-type.
Related Issues (20)
- Responsive 'px' restriction is not working HOT 4
- Fallback with media queries HOT 3
- Use 'em' instead of 'px' for 'font-range' HOT 1
- More flexibility?
- Safari 9+ buggy with px/em/rem units HOT 16
- pixrem / cssnext incompatibility ? HOT 1
- em units are not working HOT 5
- README example --- incorrect
- Percentage root font sizes don't work HOT 2
- based on height? HOT 7
- error in Chrome Develop Tool's mobile debug HOT 1
- Publish v1.0.0 on npm registry HOT 2
- Responsive line-height with default parameters does not work HOT 6
- Default media queries being added when using rems to set font sizes HOT 1
- Rename min-font-size to font-min-size like in CSS Fonts Module Level 4 HOT 1
- Doesn't work with css variables HOT 1
- problem when prefix `::placeholder` HOT 1
- Compatibility with PostCSS 8 HOT 1
- Publish the latest changes as a new version, publish to npm
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postcss-responsive-type.