Giter Club home page Giter Club logo

jknotificationpanel's People

Contributors

macfeteria avatar readmecritic avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

jknotificationpanel's Issues

[!] Pods written in Swift can only be integrated as frameworks; add `use_frameworks!` to your Podfile or target to opt into using it. The Swift Pod being used is: JKNotificationPanel-library

this looks like the best library available.
(Although looking to integrate this into an existing project - it's a shame you don't support a title + message.)

โžœ Example pod install

[!] Invalid Podfile file: [!] Unsupported options {:exclusive=>true} for target JKNotificationPanel-iPhone..

from /Users/johndpope/Downloads/github.com/JKNotificationPanel-master/Example/Podfile:4

-------------------------------------------

target 'JKNotificationPanel-iPhone', :exclusive => true do

pod "JKNotificationPanel", :path => "../"

-------------------------------------------

fyi https://github.com/bryx-inc/BRYXBanner

Linebreak not working when used in UISplitViewController

Hi again,

sorry to bother you again and again. I am trying to use this productive, so I stumble about some issues during testing.

When using JKNotificationPanel with a long text (as in the demo), the text is cut off when being using in a UISplitViewController's DetailView:

screenshot 2016-04-12 13 21 59

Should be "Offline Mode: Detailed product information, images and datasheets are not available when offline."

Edit: Rotation height is broken too, when used in a UISplitVC. After rotation the Panel is cut of at the top (a few pixels).

How to reproduce:
Create UISplitViewController from Xcode project templates, add JKNotification Panel to Detail View. Try to show a long text and/or rotate. Best seen when setting .AllVisible property of SplitView (splitViewController.preferredDisplayMode = UISplitViewControllerDisplayMode.AllVisible), so the Master View does not hide when shown portrait on iPad.

Any idea?

Bug with Custom Color in Demo and missing rotation handling

Looks great, thanks for publishing!

Two bugs I noticed when trying the demo:

  • Text for Custom Color is positioned slightly off the center. "Success with
    custom color" should be a little lower.

screenshot 2016-03-26 22 47 35

screenshot 2016-03-26 22 47 37

- Rotation handling is not implemented at all:

screenshot 2016-03-26 22 48 57

Basic resizing should be easy to implement using autoResizingMask [.FlexibleWidth, .FlexibleHeight] for the bannerView and Label with translatesAutoresizingMaskIntoConstraints = true. Regarding the position, looks like a constraints to topLayout is needed.. UINavigationBar usually resizes upon rotation.

Cheers,
Frederik

Register Selector

Could you add the possibility to add a selector or send a notification when the panel was touched? I would like to show the panel if the app found a problem and the user should be put to the screen where he can solve the problem when he taps the panel.

Bottom notification

I'd like to show the notification at bottom.

Something like:

   public func showBottomNotify(withStatus status: JKType, inView view: UIView, message text:String? = nil) { 
      let panelSize = CGSize(width: view.frame.size.width, height: defaultViewHeight)
      let defaultView = self.defaultView(status,message: text,size: panelSize)
      verticalSpace = UIScreen.mainScreen().bounds.size.height - defaultView.frame.size.height
      self.showNotify(withView: defaultView, inView: view)
   }

Naming of enableTabDismiss & Dismiss Animation

Two last small things:

Shouldn't Tab be named Tap? Guess that's a typo (and even if changing it breaks the Api, this is easy to fix for previous users).. You used that name in the Handlers, Actions, Protocol etc.

And the other thing: Is there a way to get some kind of fadeOut Animation when tapping the panel to dismiss? Probably something like the automatic fadeOut?

Edit: Not very DRY but using your code from animateFade() in dismissNotify() too should do the trick.

public func dismissNotify() {
        if let view = self.view {
            var frame = self.view.frame
            frame.size.height = -10

            let fade = {
                self.view.alpha = 0
                self.view.frame = frame
            }

            let fadeComplete = { (success:Bool) -> Void in
                view.removeGestureRecognizer(self.tapGesture )
                view.removeFromSuperview()
                self.view = nil
                self.withView = nil

                if let delegate = self.delegate {
                    delegate.notificationPanelDidDismiss()
                } else if let userDismissAction = self.dismissAction {
                    userDismissAction()
                }
            }

            UIView.animateWithDuration(0.2, animations: fade, completion: fadeComplete)
        }
    }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.