mac- / hapi-statsd Goto Github PK

hey there,

i was just going through the code, because i want to use this plugin. I'm just wondering if there's a reason you're using a cache for keeping track of the request ids ? looking at the latest hapi api, each request contains already a timestamp for when it came into the system. So to get the startDate one can just use request.info.received, which would make this cache object obsolete, the code simpler and the memory-footprint lower. if you're confident with that i would like to add a PR for that.

When I try to add 'hapi-statsd' i get the error below. Looks like it requires Hapi.js 6.9.0 and current version is 6.11.0. Is it possible to adjust the version to e.g. "6.x.x" ?

npm ERR! peerinvalid The package hapi does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants hapi@>=2.x.x
npm ERR! peerinvalid Peer [email protected] wants hapi@>=2.x.x
npm ERR! peerinvalid Peer [email protected] wants hapi@>=2.x.x
npm ERR! peerinvalid Peer [email protected] wants hapi@>= 2.x < 7.x
npm ERR! peerinvalid Peer [email protected] wants [email protected]

Any plan to port this to hapi 17?

First of all, great work on this plugin. It works flawlessly and does a great job.

We are looking to use it and need to find a way to limit which endpoints we generate statistics on. We need a way to define which endpoints get statsd metrics, and which status codes. I have several questions about this:

• Are there any plans to add such a feature?
• If not, do you recommend any other implementations?
• If not, and if we fork and develop such options, would you be interested in reviewing and merging them into this plugin?

We're asking these questions to decide whether we should attempt to contribute to this code base, or go with our own implementation.

Thanks!

statsdClient.timing(statName, startDate);

Shouldn't that be something like:
statsdClient.timing(statName, new Date() - startDate);

Otherwise you are just logging the start date and not the actual time it took to execute.