ma4nn / fritzbox-munin-fast Goto Github PK

Hi there.

I have some suggestions what you could maybe change:

• #!/usr/bin/env python -> #!/usr/bin/env python3
• add an useTls env variable witch you can define in the plugin-conf.d/ folder

fritzbox_smart_home.py.txt

An attempt to extend smart home monitoring from temperatures to switch states, power values, power consumption and temperatures as a multi graph plugin.

FritzStatus::bytes_received and FritzStatus::bytes_sent
see https://fritzconnection.readthedocs.io/en/latest/sources/library.html#fritzstatus

Solved runtime error
I am experiencing runtime errors for serveral plugins because of line 40 in fritzbox_file_session.py:
def load(self) -> None | str:
Might be related to a Python version below 3.10 (3.9.2 is current on Raspberry Pi OS) and can be solved by adding "":
def load(self) -> "None | str":
All plugins run smoothly after this change.
[I included this in my pull request]

https://fritzconnection.readthedocs.io/en/1.3.2/sources/library.html#fritzstatus
See also oe73773@77168af

And here's the fix:

Line 37:
connection = FritzConnection(address=config.server, password=config.password, use_tls=config.useTls)
needs to be replaced by
connection = FritzConnection(address=config.server, user=config.user, password=config.password, use_tls=config.useTls)