Giter Club home page Giter Club logo

adskipper-extension's Introduction

Hello ๐Ÿ˜„

I am Mileta Dulovic, a 25 years old Front End Developer from Podgorica, Montenegro.

Language and tools

HTML5

CSS3

Sass

JavaScript

React

Gatsby

GraphQL

GitHub

Git

Terminal

adskipper-extension's People

Contributors

m1ck0 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

adskipper-extension's Issues

Does not skip midroll ads

Firefox Version 122.0 (64-bit)
Adskipper Version 2.8
Used together with SponsorBlock 5.5.3 (dont know if they interact)

Making Youtube Slower and sometimes detects ad skipping

I'm noticing that when ad skipper is on it slows down the youtube webpage for me. It takes few seconds for the page to load. Sometimes video's a take a few seconds to load.

Also sometimes it still detects ad skipper.

I'm on chrome

Adskipper doesn't work

That's what the error code is:

TypeError: Cannot read properties of undefined (reading 'querySelector') at clickSkipButton (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:4:32) at stopYoutubeAd (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:23:7) at MutationObserver. (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:74:13)

YouTube Playback Problems

I noticed that videos within Reddit embeds have audio but no video and have narrowed it down to the AdSkipper extension.

It's happening for me in both Chrome and Edge. I am on version 3.2.

Example video: https://old.reddit.com/r/ROGAlly/comments/1dfwtgj/gamers_nexus_asus_sit_down/

(You need Reddit Enhancement Suite installed to have the embeds show inline)

Another odd thing is when I click through the video it appears to play twice, with one feed more delayed, but when I pause the video it continues playing.

chrome_oIfC85EZh5

Youtube detects Adskipper

Hello! Extension has been working absolutely amazingly until now, but it seems that as of May 30 something has changed in the API - Youtube now detects the adskipper and gives you the adblock warning.

Unsure if this is something that can be fixed at all, but I'd thought I'd let you know here at least.

Thanks for all of your work thus far. It's been very appreciated ๐Ÿ‘

Video becomes its own embed

image
Video player becomes its own embed and sometimes plays the video underneath as well as the embed too, with 2 players playing at the same time. I have to pause the "undervideo" by clicking on the page and pressing the spacebar, then it would make the video more tolerable. Unfortunately, this does not mark the video as watched and my recommendations on the home page get clogged up with videos I have already watched (that I watched thru the bugged embed). Is this normal behavior for Ad Skipper?

RECORDED ERROR:
ReferenceError: removePageAds is not defined at stopYoutubeAd (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:205:5) at chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:331:13 at Array.forEach () at MutationObserver.observerCallback (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:327:15)

Ad skipper does not skip full-screen sections of certain ads

When YouTube plays certain ads, it sometimes shows up a full-screen pop-up that has a button to the official website of the ad; it goes away after a few seconds. Ad skipper does not skip that apparently. And when the pop-up disappears or is skipped, the video you want to watch instantly ends.
image

Youtube Detecting the Extension

Youtube Detecting the extension as of today. Videos no longer play due to Youtube detecting an Ad Blocker. No other Ad Blockers installed.
On Chrome, and no errors on the Options Page.

Only Members videos get blocked with 3.2 version.

One of the channels I'm a member of, released a new video only for members.
However I got stopped from watching it with the message saying I'm not a member.
Once I deactivated the Adskipper I was able to watch it.

No errors are shown in the options log.

Version 3.2

Second ad plays after first normally, but can be skipped without timer

After fixing the issue I mentioned #issue-2103567400, the first ad is skipped but the second one plays normally, and sometimes, the full-screen banner still shows up.

Unfortunately, I don't know how to open an issue back up, since I don't see an option in my issue to do so, so I opened a new one just in case.

Detected by youtube

่žขๅน•ๆ“ทๅ–็•ซ้ข 2024-04-19 124333
่žขๅน•ๆ“ทๅ–็•ซ้ข 2024-04-19 124649
่žขๅน•ๆ“ทๅ–็•ซ้ข 2024-04-19 124835
่žขๅน•ๆ“ทๅ–็•ซ้ข 2024-04-19 124903

Starting yesterday, YouTube detected my adskipper, and then today I updated my extension to latest version but nothing changed. I also screenshot the errors shown in Developer Mode, not sure it will help or not.

Video losing player controls

Thanks for the extension, it's working greatly for most of the cases ๐ŸŽ‰

I noticed that after using this AdSkipper, I lost control over the video player controls. It's not focused on the controls anymore so clicking space (to play/pause) and the arrows (forward, backward, volume up/down) doesn't work.

It seems the implementation adds an iframe to the page on top of the actual video player (z-index?). Is it possible to keep the video player controls from the iframe focused rather than the actual youtube video player? That way it would keep the same behavior as youtube, meaning, if you click any part of the page, it gives control back to the video player control.

[Feature] In-feed ad blocking

One thing I'd like to see would be in-feed ad blocking. For ad banners & promoted/ad videos that show up in YouTube search results and the YouTube Home page. I think this would be a great addition.

Adskipper does not skip surveys.

I just experience a time where adskipper does not skip surveys. You have to wait 5 seconds for it to go away.

Maybe this helps?
TypeError: Failed to set the 'currentTime' property on 'HTMLMediaElement': The provided double value is non-finite. at stopYoutubeAd (chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:22:27) at chrome-extension://dinhbmppbaekibhlomcimjbhdhacoael/scripts/youtube.js:84:15

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.