lxqt / libsysstat Goto Github PK

Expected Behavior

I expect "sysstat" panel applet to display correct memory usage. When I open heavy applications to use all my memory and then close all applications, I expect to have memory usage by applications to be slightly bigger than after reboot. Tools like top, htop, mate-system-monitor show memory usage that I expect.

Current Behavior

After stopping all heavy applications, I have 6GB memory usage shown by "sysstat" applet, while other system monitors show less than 1GB. This is due to libsysstat reports incorrect values to the applet.

Possible Solution

The formula which calculates the amount of memory used by applications in libsysstat does not take into account the reclaimable memory.

A possible solution is attached. The formula is taken from htop.

0001-Application-memory-usage-formula-agree-with-htop.zip

Steps to Reproduce (for bugs)

See "Expected Behavior".

Context

I would like to receive adequate information about memory usage.

System Information

• Distribution & Version: Debian 10
• Kernel: 4.19.0-11-amd64
• Qt Version: 5.11
• liblxqt Version: liblxqt0 0.14.1-1
• Package version: libsysstat-qt5 from git master.

Lines 5-6-7
set(MAJOR_VERSION 0)
set(MINOR_VERSION 3)
set(PATCH_VERSION 1)

Line 164
VERSION ${MAJOR}.${MINOR}.${PATCH}

same reasons as for other libs - if we consider not to have a qt5 suffix we should be strict with it - but this would break razorqt in debian. Set the version to 1 would prevent this.

Ported from lxqt/lxqt#75

libsysstat hasn't changed at all since LXQt 1.0.0, and so, I think there's no need to bump its version artificially.

Is there any objection to using libsysstat-0.4.6 in LXQt 1.1.0?