lwsjs / lws Goto Github PK

Related issue: lwsjs/local-web-server#148

What do you think about using the https://allcontributors.org/ bot to automatically generate a contributors section on README?

I think this is a good way to welcome more contributors.

As I'm working on the issue #13 I'm writing here a first version CONTRIBUTING.md guidelines, using as references:

• https://www.contributor-covenant.org/pt-br/version/1/4/code-of-conduct/
• https://github.com/atom/atom/blob/master/CONTRIBUTING.md#i-dont-want-to-read-this-whole-thing-i-just-have-a-question
• https://reactjs.org/docs/how-to-contribute.html

Is that ok?

When the CLI module errors out, it simply logs it and then quits with a zero (success) exit code.

I propose adding process.exitCode=1 to lws/lib/cli-app.js under Line 25.

If necessary, this can be behind a command line option such as --use-exit-code if worried about existing implementations.

I'm storing my config in lws.config.js, in my project root. Running npx lws results in a stackdump:

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'
    at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:777:11)
    at Loader.resolve (internal/modules/esm/loader.js:88:40)
    at Loader.getModuleJob (internal/modules/esm/loader.js:241:28)
    at Loader.import (internal/modules/esm/loader.js:176:28)
    at importModuleDynamically (internal/modules/esm/translators.js:114:35)
    at exports.importModuleDynamicallyCallback (internal/process/esm_loader.js:30:14)
    at getStoredConfig (file:///C:/Workspace/my-project/node_modules/lws/lib/util.mjs:60:7)
    at LwsCli.getConfig (file:///C:/Workspace/my-project/node_modules/lws/lib/cli-app.mjs:137:32)
    at LwsCli.start (file:///C:/Workspace/my-project/node_modules/lws/lib/cli-app.mjs:26:33)
    at file:///C:/Workspace/my-project/node_modules/lws/bin/cli.mjs:5:5

The problem is that this dynamic import is getting the Windows-style literal path C:\Workspace\my-project\lws.config.js instead of a file URL. Since you already require a pretty modern Node, I think you can safely use pathToFileURL which should work correctly on any platform.

I think the SSL certificate that gets bundled here has already expired.

So using --https won't work anymore on Chrome for example.

Hi,

I faced a weird bug, while trying to load some custom made middleware. The console output an error about my middleware not being found. After some investigation I found that custom middleware are expected to be in a path in lower case (see this line)

This is a very big assumption as many filesystem are case sensitive. Would it be possible to get rid of that limitation ?