luuuk / screwthereview-server Goto Github PK

Right now, we're selecting an experience from the list returned from the yelp Search businesses endpoint. This endpoint returns a finite number of results - we should consider adding random offsets to the endpoint to truly select a random business

The current API endpoint (as is currently described in the README) does not accept parameters for search radius and keyword that are collected by Search.js to filter an experience.

This comment should be addressed from Peer Review:

I could build the software, following the provided instructions, on a machine matching the prerequisites mentioned in the instructions.

• "True, however, instructions in developer guide for server (in luuuk wiki) for API call to server or local development did not tell me how to make a search request. I tried adding /search?location=Seattle or something to the url but they do not work. It will be nice to show us an example Get request to show
  us how to use it."

This should be addressed from peer review feedback:

I could test the software, following the provided instructions:

• "For luuuk’s server repo, if I try to run all the tests using yarn test, it will try to run localServer test first and since it is commented out, it will not pass. Running individual tests, such as sample test and server test, will pass."

Let's try to get this to say STR!

This may have been fixed w heroku but still should be investigated