lunamultiplayer / cachedquicklz Goto Github PK

The problem with this code is that the Stack that it Pops is not thread safe. So between the methods/getters on the ConcurrentSet Bins, there can be something that happens; especially during Stack.Pop or the ternary operator in the assignment (they are also nonatomic), that would result in undefined behaviour, for instance the same element getting popped twice.

However, this issue is somewhat unlikely to be causing LunaMultiplayer/LunaMultiplayer#195, because WriteHeader has no easily conceivable way of writing the bits as 10, only 11 or 01. However, it could happen that the data is entirely garbled because multiple writes to the same variable could be cached; and byte writes are seldom atomic.