lukenskyne / minecraft-ping-wheel Goto Github PK

this feature is based on the game Deep Rock Galactic, where a Dwarf pings a gold piece and says "we are Rich!"

this could be by default off and changed to custom "voice lines / audio files".

Request support for non mandatory use of mod by the client, that is, optional installation by the client after the server is installed, not mandatory installation. The server data is only provided to users who install similar mod and users who have not been installed are not affected....
I don't know if this can be achieved, but I hope to have this feature. Or it has been implemented but I haven't found any configuration features..
Thank you for your hard work. I really like this mod!!!

it would be nice to see a server side plugin so this mod can work on paper servers

this doesnt seam to work on multiplayer servers

• Ability to mute / not see pings option

• Maybe a feature that implements a team system so pings can only be shown for those in a party? This would probably lead to a config:
  "Use team feature so pings are only shown from team members" if there's quite a bit of people,
  OR automatically disable pings from non-team members and have a config: "Allow pings from non-team members" if you don't need the team feature!
  I feel like this could be super beneficial in smps so only team members can see each other's pings!

Hi,
I noticed that this mod does not support Bukkit servers, so I wrote my own plugin implementation with extensive configuration.
Here it is: https://github.com/SandResidence/PingWheelBukkit

Preflight Checklist

• I am using the latest version of Ping Wheel for the corresponding mod loader.
• The server I am playing on has Ping Wheel installed.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Which mod loaders have you experienced the issue with?

Fabric

What versions of Minecraft have you experienced the issue in?

1.20–1.20.1

Expected Behavior

Ping locations should be placed on the screen where the cursor is.

Actual Behavior

The ping displays on my screen off to the side, sort of "orbiting" around the correct position.

Logs URL

https://mclo.gs/M6aDMPV

Additional Information

The actual marker in the game world seems to be correctly located, because the distance to the spot I mark is accurate, but the on-screen display of where the location is doesn't work correctly at all for me.

In this screenshot, I have pinged the wall directly in front of me where the crosshair is, but the on-screen display is not positioned there. This happens no matter how near or far the location is, and it happens every time.

More information about my environment: I'm running Minecraft 1.20.1 on MacOS 14.1.1 with Java 17. My server is using Fabric 0.14.24. You can find my current modlist in the uploaded log.

id would be a cool feature if you could select the ping to be permanent by settings the slider all the way to the max, also would be cool if the entity/item would glow through walls and also if you could remove a ping by pressing the ping button while looking at a ping and maybe a settings to select the "radius" of the ping you have to look t to remove it. would be realy cool if those features would get qadded :D

Hey, can you add a feature that will bring sending pings with custom texts? To mark server side locations like spawn, npc, etc.

What it might look like:

Ping data is sent to all players. However, if the server specifies a max distance, players that are farther than that distance from a ping, won't be shown and they will not be notified.

Also maybe a way to have a ping cool down where if a players pings more than X number of times in Y amount of time, they will get a Z seconds time out before they can ping again.

Hi! I'm looking to write a mod that's similar to yours but completely client-side (i'm thinking of using specific chat messages to communicate between clients, that are understandable by non-mod-users as well, like "playername pinged 200 67 -186")

My question is, do you want to collaborate on this and add it as a feature to your mod, or shall I just write my own?
There could just be a toggle in modmenu to change how it communicates with others (through server-side mod or chat)

it would be cool if you could change the correction period time limit option from 5s to 60s. this would allow us to use the same value as the ping duration, which would effectively make every player only have one active marker at a time.

edit: speaking of values, why is ping duration an integer and correction period a float? for consistency reasons, can you make both variables use the same type?

Hey, I love this mod. Would it be possible that besides the mod you would also release a plugin for PaperMC? Similar to this one.

I would appreciate native support from this repository, not only for modded servers like Fabric, but also for plugin servers like PurpurMC, because I think many people like to use this mod on servers that are not modded servers.

I also think that you don't need a huge config for the plugin. Maybe just that you could restrict certain channels or something like that.

Thanks for consideration. 👍🏻

this is a fantastic mod, can you backport it to 1.16.5? i'm not familiar with 1.16.5 yarn, so i can't do it by myself

It would be nice to be able to have it as an option to be able to activate an icon to see where you last died!

Preflight Checklist

• I am using the latest version of Ping Wheel for the corresponding mod loader.
• The server I am playing on has Ping Wheel installed.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Which mod loaders have you experienced the issue with?

Fabric

What versions of Minecraft have you experienced the issue in?

1.20.2

Expected Behavior

I would expect the client not to crash.

Actual Behavior

When I am alone on the server, the ping wheel works as expected.
When I try to ping with at least 2 players on the server, the server throws an exception and the client crashes / disconnects.

Error message:

[11:07:47] [Netty Epoll Server IO #1/ERROR]: Encountered exception while handling in channel with name "ping-wheel-c2s:ping-location"
java.lang.IndexOutOfBoundsException: readerIndex(75) + length(1) exceeds writerIndex(75): UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 75, widx: 75, cap: 256)

Logs URL

https://mclo.gs/R5eKsCn

Additional Information

Initially, I had FerriteCore and Memory Leak Fix installed. I removed them to narrow out compatibilty issues.

The issue persists after removing both mods.

Edit:

I set up a minimal example to recreate the issue.

Server

• Java 17
• Minecraft 1.20.2
• fabricloader 0.14.24
• fabric-api 0.90.7+1.20.2
• carpet 1.4.121+v231011
• ping-wheel 1.6.0

Client

• Java 17
• Minecraft 1.20.2
• fabricloader 0.14.24
• fabric-api 0.90.7+1.20.2
• ping-wheel 1.6.0

After adding a carpet bot with /player Steve spawn the same error is thrown after pinging.

Server Logs (minimal example)

https://mclo.gs/HIPygCm

I do not know if this feature is in here, but I want to lock the settings for players that join the server. Things like limiting the distance of a ping, and removing the 'global' channel for pings.

Hi, i really like your ping wheel mod. My minecraft squad usually fights with others and we actually need this mod but just for client side, because we play on on other servers that don't have this mod.
I know that would be really hard to add, but this would be very useful for us. Thank you

With both this mod and the mod Immersive Portals installed, pings do not work beyond roughly 29m; nothing visibly happens when pressing the ping button, and a "raycast too far" error is output to the log. Tested on 1.20.1 both with Fabric and with Quilt, and with a couple of different versions of Ping Wheel and of Immersive Portals. Attached is an example log file containing the error.

Apologies if this turns out to be an issue that needs fixed by Immersive Portals rather than Ping Wheel; I wasn't sure where this should be reported. 😓

Hi there! First of all, thank you for developing such an awesome mod, it's extremely useful!
I would like to know if there are plans of updating it to 1.20.6 anytime soon? It's one of the essential mods that I would wait for, before upgrading to 1.20.6!

Im having an issue where I can't make any pings I've confirmed that im using the correct version and I've set a channel in the config.

• Add a texture to ping icon
• Add an icon size slider in mod settings

For example, I want the default ping to look like this:

This result can be achieved by modifying size and texture

Hey,
I'd love if you made this for forge! the forge mod you got inspired by isn't getting updated and doesn't work with shaders.
Thanks,

A backport would be amazing, this is really really helpful, I hope you can port it to 1.18.2!

Preflight Checklist

• I am using the latest version of Ping Wheel.
• The server I am playing on has Ping Wheel installed.
• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What versions of Minecraft have you experienced the issue in?

1.19.4

Expected Behavior

After placing mod in .minecraft/mods both on client and server, I just wanted to launch Minecraft and play.

Actual Behavior

After opening Minecraft client every text characters appears as rectangle symbol. I guess, there only one language left.

Additional Information

After removing mod from mods folder, everything returns back to normal state.
I use Fabric Loader v0.14.24 and Ping Wheel v1.5.1

Would be great if the block and entity would glow, in the same fashion as Vanilla Pings
The glowing effect could come in addition to the icon & distance display, and could be disabled from the mod's settings.

Example from Vanilla Pings :

Hi, I'm generally a huge fan of pinging systems in games so I love this mod!
I'm not sure where I could ask you this, but I'm currently in the process of rewriting it purely in java as I'm currently learning java; I've also made a few changes and I was wondering if I'd be allowed to publish it as a mod (with credit)