lukaspustina / netatmo-rs Goto Github PK

Thx for the nice work. On example get_station_data I get

Finished dev [unoptimized + debuginfo] target(s) in 0.07s
Running target/debug/examples/get_station_data
thread 'main' panicked at 'Failed to get station data: Error { inner: Error("missing field pressureunit", line: 1, column: 1393)

failed to deserialize JSON }', examples/get_station_data.rs:36:10
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Looking into it (however rust newbie)

Right now StationData only has private fields, which makes it pretty much useless 🙂 Or am I missing something?

When querying the station data for a device ID that does not exist, currently the error is Error { inner: Error { inner: Error("missing field body", line: 1, column: 49) failed to deserialize JSON }. The body looks like this:

{"error":{"code":9,"message":"Device not found"}}

It would be nice if this would be handled more gracefully, e.g. by returning a "device not found" error (or at least an error that contains the error code and message returned by the API) 🙂