What will happen when calling min_waypoints(1)? about awe HOT 3 CLOSED

Hi,

Thanks for pointing this out! We have fixed the issue in the latest commit by adding an additional check on the error threshold. Now, it should return all points as waypoints if the threshold is excessively low.

We apologize for the inconvenience. We tested on very low error thresholds to ensure that the algorithm would return more than half of the points as waypoints, but we probably didn't stress test it enough... Again, thanks for catching this!

P.S. In practice, you would not want to choose a threshold so low that every point gets selected. A rule of thumb for us is to pick a threshold that selects about 1:8 points as waypoints; however, this is task- and environment- dependent of course.

from awe.

Hello Lucy,

Thank you for the update!

btw, you delete the recursive version of dynamic programming in the code, which seems to be the algorithm in your paper. Is the non-recursive version better?

Kind regards,
Zhuoheng

from awe.

Hi Zhuoheng,

The version I removed is a legacy implementation of DP (you may have noticed a comment "backlog" in its header). We actually call the iterative implementation of DP, which is conceptually the same but faster than the recursive version (by pre-computing the result of all recursive calls). I removed it since this legacy version seemed to cause confusion.

Best,
Lucy

from awe.