[Bug] if compile error when running lucky db.migrate.one, the migration status get migrated unexpectly. about avram HOT 4 CLOSED

I really think the better option is to use env() to specify when you want to control a specific task.

# does not run migration
lucky dev

# runs migration
MIGRATE=true lucky dev

from avram.

Hi, i guess why this issue happen.

I added following code into my config/database.yml

if !LuckyEnv.task?
  Avram::Migrator::Runner.new.run_pending_migrations
end

I thought it should never run when start server use lucky dev, because i thought
lucky env is a task, right? but this not true obviously.

so, the migration file get migrate immediately when i generating it use bin/lucky.gen.migration ...

So, the new issue is, how to check current server is running from lucky dev? i consider only check $LUCKY_DEV == development is not enough for my case, i just don't want lucky dev run my migration, but, it should be running if i run shards build or lucky db.migrate.one.

Thanks

from avram.

Maybe you can use a compile env for this case?

# config/database.cr
{% if env("MIGRATE") %}
Avram::Migrator::Runner.new.run_pending_migrations
{% end %}

MIGRATE=true lucky db.migrate.one

from avram.

Maybe you can use a compile env for this case?

# config/database.cr
{% if env("MIGRATE") %}
Avram::Migrator::Runner.new.run_pending_migrations
{% end %}

MIGRATE=true lucky db.migrate.one

I consider this is not correct,, whatever whether env MIGRATE was set, db.migrate.one always run pending migration.

For now, i change to run pending migrate only in production

if !LuckyEnv.task? && LuckyEnv.production?
  Avram::Migrator::Runner.new.run_pending_migrations
end

But, i still prefer to check if running with lucky dev, anyway, i consider unless running with lucky dev, other cases run migration automatically is always a good idea?

from avram.