Comments (8)
In short:
- fork lucas repo.
- "git clone" your forked repo to your local computer.
- Make your chages.
- "git commit" to your local repo.
- "git push" to your forked repo.
- Visit github and the tool will ask you to create a PR with your changes.
- Delete your fork and local repo.
Here you have github's howto:
https://help.github.com/en/articles/creating-a-pull-request
from ojs.
Thats awesome @Potomac54, the error occurs because supervisor normally need an service to be running, and the exit of ojs-pre-start its not a running process and i never found and work around. Can you please make a PR with that?
Or i will integrate this as soon as i'm possible.
Thanks
from ojs.
Can you tell me how can I make pull request in your github ?
Do I need to be a member of your github ?
I tried to clone your github (php7-test branch), and then make a pull with my modifications, it doesn't accept my credentials
$ git push
Username for 'https://github.com': potomac
Password for 'https://[email protected]':
remote: Permission to lucasdiedrich/ojs.git denied to Potomac.
fatal: unable to access 'https://github.com/lucasdiedrich/ojs.git/': The requested URL returned error: 403
then I tried to use the "pull request" feature of your github, but not sure to understand how it works
from ojs.
Ok I forked lucas repo, I made the change in the "php7-test" branch, and I made a pull request :
#31
from ojs.
I notice a bug in my pull request, ojs-pre-start is not started when startsecs=0,
so the solution is to set this option to 1, like this :
[program:checkstart]
command=/usr/local/bin/ojs-pre-start
startsecs=1
exitcodes=0
from ojs.
@Potomac thanks for your help, unfortunetly your second PR included breaking code, i mentioned that over the PR, thanks.
from ojs.
@lucasdiedrich @marcbria : I fixed the wrong path in a new commit,
for the supervisor problem my fix doesn't really work, sometimes I get the message "fatal state", I think the main problem is that supervisord is designed to run daemons, not really simple bash scripts,
one solution would be to start ojs-pre-start with an init system like systemd, alpine linux uses a different init software, openRC : https://wiki.alpinelinux.org/wiki/Alpine_Linux_Init_System
another solution may be to use a cron script, with settings to run once ojs-pre-start script
from ojs.
@Potomac thats exactly the problem, supervisor is designed to run daemons, using alpine init system is the best option, as soon as possible going to look into this.
from ojs.
Related Issues (20)
- Unknown charset error HOT 4
- Feature request: Make it run over play-with-docker HOT 5
- New release (and a proposal) HOT 32
- Unable to install OJS with latest tag (ojs-3_1_1-4) HOT 6
- Unable to install OJS with php7-test tag (ojs-3_1_2-0) HOT 13
- ojs-cli-install doesn't work as expected HOT 10
- Feature request : generate dynamically config.inc.php inside the container HOT 12
- Feature request : re-create automatically the database if there are no tables HOT 7
- Docker-compose not working out of the box HOT 4
- problem when the server is running with https HOT 11
- Is "file" utility present in php:7.3-alpine image ? HOT 5
- Testing latest branch HOT 2
- OJS installed by default or better not? HOT 8
- Can not upload image in an email form creation HOT 6
- Testing master branch HOT 1
- Private folder is wrong in autoinstallation querystring
- Add support for multiple OJS versions HOT 13
- New release 3.1.2-1 HOT 6
- Missing dependency for texture plugin HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ojs.