Feature request: Make it run over play-with-docker about ojs HOT 5 OPEN

OK, going to make this after the upgrade.

from ojs.

Marc, adding PWD to the docs will be an awesome upgrade, i created an test branch i made some changeds at the docker-compose.yml.

You can test at: https://labs.play-with-docker.com/?stack=https://raw.githubusercontent.com/lucasdiedrich/ojs/test/docker-compose.yml

It seems that`s is working now, i just have to add the env variables again. Can you test it??

Going to look the other issue this afternoon. Thanks.

from ojs.

Thanks a lot Lucas.

Looks like PWD don't like variable expansion and you need to hardcode the variables. :-(

What about keeping a docker-compose.yml with variables as before (for development and production environments) and create a copy (stack.yml or if it works, demo.yml) with hardcoded vars, just for PWD?

I tested and now works better than before, because the full stack is build, but when you visit the url of the site shows a WSOD till timeout.

No clue about why it happens. I will review it next week or so. We are so close.

Thanks a lot for your work and time,
m.

from ojs.

Marc, there is a reasonable for not working with .env variable, as we are just pointing to the docker-compose.yml when PWD loads this file he doesn't know the existence of the .env file over the repository.

I created this file just to test that out, i'm going to rollback it and just remove the .env lines, i think its going to work then. I'm thinking about creating an examples folder and put this docker-compose files inside it, what do you think?

Thanks.

from ojs.

I was expecting some magic from PWD but yes, it makes a lot of sense.
An examples folder with "hardcoded variables" docker-compose is a perfect solution.

But please, think in this as a "feature request"... I mean, if I were you, I will focus on the new release upgrade instead of this. ;-)

Please, let me know if you need help or you want a PR.

Thanks!

from ojs.