lucamarini22 / marine-anomaly-detection Goto Github PK

          Turbid Water changes too, but yeah I need to make a script to get this numbers automatically when running training instead of getting that beforehand

          If I was you, I would merge individual readme files into one big on the root. Otherwise, people will not find it or might discard your repo initially thinking that there are not enough docs etc.

          I would move the constants bellow (class_distr) into a separate file. Or you can make there formatting nice with

          If you want nice color-coded output with timestamps etc. like this 

          This is quite a large file with a lot of different functions some which don't have to be in this class since they are static. would consider moving some of out the class

          this is a very long file with multiple classes. would break up into individual files

          Some comments here and there. In general, I would try to break up your file structure a bit. If I read your filenames it is pretty hard to understand how things interact and in most files you have a lot of static functions, so it seems like a file is not something that combines things that have one clear purpose but just a bunch of thrown together functions. Would try to divide by purpose / activity into subfolders like : imageprocessing, io, datastructure or something like that with dedicated files for specific things

          division by 0 for white / black img :P 

          you are not dividing, not sure if intentional? if so, would remove to avoid later being confused whether you meant to divide

          open todo

          if you put your comments on the line above the code it may be less ugly. 

          open TODO

          open todo

          instead of having different arg parse in files may be nicer to have that collected in some other file? you probably need it in any your scripts?

          One thing to think about in general maybe if you want your code at all to be usable with other datasets. Because it seems to me you are writing it in a way that will make it extremely difficult to ever use any other dataset? 🤔

          I would suggest you start using cfg files and just have a debug.cfg etc. Right now it seems you are changing default values in your code all the time. This is very dangerous as you may introduce errors or forget to change things back. What I would suggest is: