lucafalasco / datalith Goto Github PK

Use @storybook/addon-notes to document all components

I am not sure about that, but I think responsability has failed with Spiral chart component, in particular with bubble positions.
When you generate spiral coordinates [1], you are not taking into account width and height, could be a problem?
I think we need to scale up/down coordinates according to actual height an width or they are going to be render outside of container. Or could be an issue related to g transform? [2] Or maybe because we are not separating correcly wrapper and bounds without taking into account margins?
What do you think about that? Am I missing something?

Thanks!

It would be useful to add mouse events handlers to each element of the data visualizations, in order to make it possible to pass a callback to handle those events to eventually trigger side effects.
This could be done similarly to how it currently works with the tooltip prop.
I think something like this could work:

interface Props {
  ...
  onMouseOver?: (e: React.MouseEvent, d: Datum) => void
  onMouseOut?: (e: React.MouseEvent, d: Datum) => void
}

At the moment opacity can only be applied to an SVG element by setting the alpha value in the fill color accessor, but rgba is currently not allowed in the SVG spec, and can generate color issues if the SVG is exported and edited with a design tool such as Adobe Illustrator.

Data could actually be sorted before being used.. Should also remove a lodash dependency