The zynqmp-pmufw-builder from lucaceresoli

zynqmp-pmufw-builder's People

Contributors

Stargazers

Watchers

zynqmp-pmufw-builder's Issues

Fatal warning -Wstringop-overflow

I get the following fatal warning when building the pmufw, the xpfw_restart.c file.
I don't think the warning is valid in this case since it is a raw memory copy.
I am curious why someone else hasn't complained about this though.
A fix is adding -Wno-stringop-overflow to CFLAGS in build.sh which I think is okay since we aren't writing any new code here and just want to compile and use the same as xilinx tools are using.

Do you want a patch for this? Or am I just bonkers.

In function 'XPfw_StoreFsblToDDR',
    inlined from 'XPfw_StoreFsblToDDR' at xpfw_restart.c:636:5,
    inlined from 'CheckFsblCompletion' at xpfw_mod_common.c:97:12,
    inlined from 'CheckFsblCompletion' at xpfw_mod_common.c:31:13:
xpfw_restart.c:656:31: warning: 'memcpy' writing 174080 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
  656 |                         (void)memcpy((u32 *)FSBL_STORE_ADDR, (u32 *)FSBL_LOAD_ADDR,
      |                               ^
In function 'XPfw_RestoreFsblToOCM',
    inlined from 'XPfw_RestoreFsblToOCM' at xpfw_restart.c:693:5,
    inlined from 'PmMasterRestart' at pm_master.c:973:13,
    inlined from 'PmSystemShutdown' at pm_core.c:1302:12,
    inlined from 'PmProcessRequest' at pm_core.c:2097:3:
xpfw_restart.c:718:23: warning: 'memcpy' writing 174080 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
  718 |                 (void)memcpy((u32 *)FSBL_LOAD_ADDR, (u32 *)FSBL_STORE_ADDR,
      |                       ^