luarocks / hererocks Goto Github PK

@hishamhm could you take a look at https://ci.appveyor.com/project/hishamhm/hererocks/builds/35418067/job/s6k82innxl02vnf4

AssertionError: Error running command 'test\here\bin\luarocks.bat --version': code 255, output:
b'The syntax of the command is incorrect.\r\n'

Hello,

hererocks has some attractive features that luaver lacks. If someone supplied the necessary patches, would you be open to adding the rest of luaver's functionality to hererocks, so that hererocks could manage global installations of lua and luarocks?

The test TestCLI.test_verbose_install_bleeding_edge_luajit_with_latest_luarocks is failing with the following output mismatch:

E                   AssertionError: Expected to see 'b'LuaJIT 2.1.0'' in output of command 'test/here/bin/lua -v', got output:
E                   b'LuaJIT 2.1.ROLLING -- Copyright (C) 2005-2023 Mike Pall. https://luajit.org/\n'

This seems like an unintentional failure. As far as I can tell, the test is succeeding: Hererocks is correctly installing the requested version, and the lua command appears to be running the correct program. It seems like this assertSuccess method needs to be adapted somehow to accommodate a prefix match, or the output from lua -v needs to be truncated.

I can't be the only one who thinks storing a patch inside a string is not ideal. On top of that, the script is not up-to-date with all the patches from https://www.lua.org/bugs.html. Plus, I might want to apply one of the Lua Power Patches. Overall, I think the cleaner solution is to deprecate the --patch option for something like --apply {names}

I'm getting CERTIFICATE_VERIFY_FAILED when using Python Version 3.8.

hererocks c:\hererocks --%LUA% --target %HR_TARGET% -rlatest
Fetching Lua 5.1.5 (target: vs_64) from https://www.lua.org/ftp/lua-5.1.5.tar.gz
Download failed: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1108)
Fetching Lua 5.1.5 (target: vs_64) from https://webserver2.tecgraf.puc-rio.br/lua/mirror/ftp/lua-5.1.5.tar.gz
Verifying SHA256 checksum
Error: SHA256 checksum mismatch for C:\Users\appveyor\AppData\Local\HereRocks\Cache\lua-5.1.5.tar.gz
Expected: 2640fc56a795f29d28ef15e13c34a47e223960b0240e8cb0a82d9b0738695333
Observed: 2598647a7dd012b6c346023638258509103d36dd3f15941aebc31c009e6a80ab

With Python 3.9 the download from https://www.lua.org works but unfortunately: Python 3.9 is not available in an Appveyor image together with Visual Studio 2015, see https://www.appveyor.com/docs/windows-images-software/

It seems that Visual Studio 2015 is the latest version supported by hererocks:

hererocks.py: error: argument --target: invalid choice: 'vs19_64' (choose from 'linux', 'macosx', 'freebsd', 
'mingw', 'posix', 'generic', 'mingw', 'vs', 'vs_32', 'vs_64', 'vs08_32', 'vs08_64', 'vs10_32', 'vs10_64', 
'vs12_32', 'vs12_64', 'vs13_32', 'vs13_64', 'vs15_32', 'vs15_64')

As a workaround I got it working by using:

• AppVeyor image: Windows Server 2012 R2
• Python Version 3.8
• Old hererocks version 0.25 without https: pip install git+https://github.com/luarocks/[email protected]
• Hererock targets vs_32 and vs_64 these are selecting VS 14.0 (x86) and VS 14.0 (x64) which seems to be Visual Studio 2015.

Some options, like -flto and -fPIE require that the same or a similar option be passed to
the linker. See the GCC documentation for -pie:

Produce a dynamically linked position independent executable on targets that support it. For predictable results, you must also specify the same set of options used for compilation (-fpie, -fPIE, or model suboptions) when you specify this linker option.

And the documentation for -flto:

To use the link-time optimizer, -flto and optimization options should be specified at compile time and during the final link. It is recommended that you compile all the files participating in the same link with the same options and also specify those options at link time.

It would be helpful to have a --ldflags option that gets passed to all the
linking commands.