lrynek / painless-car-rental Goto Github PK

It results in:

Fatal error: Uncaught Symfony\Component\Dotenv\Exception\PathException: Unable to read the "/usr/share/nginx/html/default/.env" environment file. in /usr/share/nginx/html/default/vendor/symfony/dotenv/Dotenv.php:567

Example PUT request

Creates this error:

The mapping definition cannot be nested under a type [_doc] unless include_type_name is set to true."}],"type":"illegal_argument_exception","reason":"The mapping definition cannot be nested under a type [_doc] unless include_type_name is set to true.

For the Elasticsearch v7.17.1

Request body update required or workaround by adding a query ?include_type_name=true as used in request.sh

However if a user don't use the request.sh for eg by runing setup.sh but use API clients instead then he would not be able to succeed with the original body of the example PUT request

Currently there is no information how to handle that problem in the README.md

Suggested:

• update the request body for all PUT requests or
• add information in the README.md how to handle that problem (suffix target with ?include_type_name=true)

This LICENSE mentions MIT but composer.json has "proprietary"

If composer.json should have MIT then PR 10

No matter the request (with or without filters) $referer is always lacking a query string.
Therefore return is always executed and the self::FIRST_PAGE never returned.

That leads to the issue in case a user's browser is displaying for example the 5th page

but a user makes a new search request with updated filters and a response does not have at least 5 pages:

Expected behavior would be to display always the 1st page of results every time a user requests a new page with changed filters:

If .env file is missing then why it is not mentioned in the .gitignore file taking into account that others are?

/.env.local

If .env should be present in .gitignore then PR 8

$previousQueryParams is used here but nowhere is any value assigned to it.

Call to an undefined Car::fromResult.

Cars::fromResponse may be removed - it is nowhere used.

There is always only one page having max 3 results displayed with no other available at the bottom as a pagination even when no filters are applied.

There is an entry:

/config/secrets/prod/prod.decrypt.private.php

But why it ignores a specific file instead of a whole /config/secrets/prod directory?
Are there any files planned to be there and committed to the repository?

If not then PR 6