Comments (5)
You'd just have to edit the JavaScript that I inject into the Browser to make this work. I add a click event handler to the body of the document of a webpage. You'd just have to adjust this to make it so that it works for iframes, though I imagine if there are unrelated CORS issues, that will add some extra complexity to the fix.
from jidoujisho.
Just for testing purposes, could you please supply a URL that I can use to test against this to make it easier for me to test a fix in the future?
from jidoujisho.
Screenrecorder-2023-07-27-12-03-29-257.mp4
Good morning:
I don't know any URL that uses iframes right now, sorry. Only the web of my friend.
Also I was talking with my friend and he told me that you only need to create a web and add this to create an iframe and test:
<iframe src="https://www3.nhk.or.jp/news/"/>He cannot grant you access to his web right now cause is a project for university and its not finished yet, sorry. I'm only a helper and beta tester.
I recorded a video about this problem. It's attached to this reply.
Thanks for your work!!
from jidoujisho.
You'd just have to edit the JavaScript that I inject into the Browser to make this work. I add a click event handler to the body of the document of a webpage. You'd just have to adjust this to make it so that it works for iframes, though I imagine if there are unrelated CORS issues, that will add some extra complexity to the fix.
Hello, I am the friend 😂, by "adjust the event handler" you mean to create a pull request with the changes? because as far as I know there is no way to modify code injected by the browser.
I got the app to recognize the text inside the iframe by replacing the getSelection function in my website, but I don't think I can do anything about the event listener. I cloned the click event from the iframe and triggered it in the parent, but the app won't find text because it searches for it in the parent document.
Thanks
from jidoujisho.
That is the case, yeah. Truth be told, the browser was a popular request, one that I don't use myself regularly but I see the benefits for. I was initially hesitant exactly for the reason being web is web and there are a lot of edge cases out there.
I don't have time at present to make the changes myself as while this is a pretty significant issue, it's also not really very common (though it is also not super rare, it's also not a media source I commonly use).
Plain JavaScript isn't my forte suffice to say but I'll leave this open for the web devs, or me sometime when I'm not pressed with work lol
from jidoujisho.
Related Issues (20)
- ebooks shortcuts
- Can't capture the subtitle' audio clip from pure audio files HOT 2
- Go back to library from mokuro view HOT 1
- instant export shortcut button doesn't work HOT 2
- Remember external subtitle selection and time
- keeping older anki compatibility HOT 7
- Buttons are too small on tablets HOT 3
- [Feature] is there a feature where we can open subtitle without playing or opening the video HOT 1
- Ability to use my own anki card templates (enhancement) HOT 4
- This tag "Yuuna" keeps appearing on my cards? HOT 6
- Books disappeared from menu screen but they are still in ッツ Ebook Reader
- Selected text > creator > doesn't carry selected text to term field
- [Feature] Subtitle position/height offset
- There wan an error in adding note to ankidroid HOT 5
- Video player turning black after switching between apps HOT 2
- Can I use a third-party HTTP API to translate the text? HOT 1
- Crash/Black Screen on launch after leaving app
- Issues with using newlines HOT 3
- Unable to Open Local Media HOT 1
- Insufficient performance in parsing long video's subtitles and somehow a correlation to timestamps not saving properly ( my layman's recount of this issue) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jidoujisho.