lostisland / faraday-multipart Goto Github PK

View Code? Open in Web Editor NEW

16.0 16.0 4.0 41 KB

Perform multipart-post requests using Faraday.

License: MIT License

Ruby 98.51% Shell 1.49%

faraday-multipart's People

Contributors

Stargazers

Watchers

Forkers

isabella232 jsvd ccarse holycrypto

faraday-multipart's Issues

Ruby 3.1.1

I am getting the warning:

/home/.../gems/faraday-multipart-1.0.4/lib/faraday/multipart.rb:17: warning: already initialized constant Faraday::Parts
/home/.../gems/faraday-0.17.5/lib/faraday/upload_io.rb:66: warning: previous definition of Parts was here
/home/.../gems/ruby-3.1.1/gems/faraday-multipart-1.0.4/lib/faraday/multipart.rb:18: warning: already initialized constant Faraday::CompositeReadIO
/home/.../gems/ruby-3.1.1/gems/faraday-0.17.5/lib/faraday/upload_io.rb:12: warning: previous definition of CompositeReadIO was here
/home/.../gems/ruby-3.1.1/gems/faraday-multipart-1.0.4/lib/faraday/multipart.rb:21: warning: already initialized constant Faraday::UploadIO
/home/.../gems/ruby-3.1.1/gems/faraday-0.17.5/lib/faraday/upload_io.rb:65: warning: previous definition of UploadIO was here

ruby 3.1.1
faraday v.0.17.5
faraday-multipart v.1.0.4

Can you please make changes to get rid of that?

Uploading file in chunks using range header

Basic Info

Faraday Version: 1.9.3

Issue description

I’m trying to use Faraday to upload a file to Azure Blob Storage, which has a limit (of 268435456 bytes) for the body of each request. Larger requests must be sent in chunks using a Range or x-ms-range header. Is there a way to do that with Faraday using multipart / FilePart or otherwise?

I looked at the implementation of FilePart, which seems to support passing an IO object instead of a file path, but I’m not sure if there's a way to limit such an object to just a subsection of a file?

Here is the code I’m currently using, which works fine for files below that limit:

Faraday.new(headers: {'x-ms-blob-type': 'BlockBlob'}) {|c|
  c.request :multipart
  c.response :raise_error
  c.adapter Faraday.default_adapter
}.put(fileUploadUrl, {file: Faraday::FilePart.new(filePath, 'application/octet-stream')})

Any help would be appreciated!

`Content-Disposition` header overwrite fails

I am trying to overwrite the Content-Disposition header.

For the third party API, I need a very specific filename that includes /.
I noticed the Content-Disposition header is not entirely overwritten. It still adds the default name and filename.

require 'faraday'
require 'faraday/multipart'

connection = Faraday.new(url: 'http://localhost:3000') do |connection_builder|
  connection_builder.request :multipart
  connection_builder.response :logger, nil, { headers: true, bodies: true }
end

payload = { file: Faraday::Multipart::FilePart.new('test.txt', 'text/plain', nil, 'Content-Disposition' => 'form-data; name="file"; filename="foo/bar"') }

connection.post('path', payload)

It creates

Content-Disposition: form-data; name="file"; filename="foo/bar"; name="file"; filename="test.txt"

instead of

Content-Disposition: form-data; name="file"; filename="foo/bar"

I was also trying to give the file name as a parameter to the FilePart.new.

require 'faraday'
require 'faraday/multipart'

connection = Faraday.new(url: 'http://localhost:3000') do |connection_builder|
  connection_builder.request :multipart
  connection_builder.response :logger, nil, { headers: true, bodies: true }
end

payload = { file: Faraday::Multipart::FilePart.new('test.txt', 'text/plain', 'foo/bar') }

connection.post('path', payload)

It creates

Content-Disposition: form-data; name="file"; filename="bar"

while I need

Content-Disposition: form-data; name="file"; filename="foo/bar"

Signpost issue: release a 2.0 version

There are these constants which are for the use of faraday 1.x, and we've moved them around, keeping aliases around.

It could be time to release a new major, where these are removed.

Example comment:

Aliases for Faraday v1, these are all deprecated and will be removed in v2 of this middleware

Image is not saving with post request

I have author class using active storage.

              class Author < ApplicationRecord
                  has_one_attached :image
              end

post request

             require 'faraday'
             require 'faraday/multipart'

             payload = { author: {title: "lo"} }
             payload[:author][:image] = Faraday::Multipart::FilePart.new(File.open(Rails.root.join('app', 'assets', 'images', 'about.jpg')), 'image/jpeg')

             conn.post('/api/v1/authors', payload.to_json)

My received params

         #<ActionController::Parameters {"author"=>{"title"=>"lo"}, "image"=>{"content_type"=>"image/jpeg", 
         "original_filename"=>"local.path", "local_path"=>"local.path", 
          "io"=>"/home/kashif/ticket_plot_api/app/assets/images/about.jpg", "opts"=>{}}, "controller"=>"api/v1/authors", 
           "action"=>"create"} permitted: false>

Author is saving without image

Is anything wrong?
Thanks

Use new multipart-post 2.2.0 release

The 2.2.0 was just released, and we should use that, avoiding deprecation warnings (it changed its file structure to something better; if we use the existing structure, it works but we get warnings).

https://github.com/socketry/multipart-post/releases/tag/v2.2.0

lostisland / faraday-multipart Goto Github PK

faraday-multipart's People

Contributors

Stargazers

Watchers

Forkers

faraday-multipart's Issues

Ruby 3.1.1

Uploading file in chunks using range header

Basic Info

Issue description

`Content-Disposition` header overwrite fails

Signpost issue: release a 2.0 version

Image is not saving with post request

Use new multipart-post 2.2.0 release

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent