lorisleiva / cron-translator Goto Github PK

View Code? Open in Web Editor NEW

276.0 276.0 53.0 143 KB

⏰️ Makes CRON expressions human-readable

License: MIT License

PHP 100.00%

cron-translator's People

Contributors

Stargazers

Watchers

cron-translator's Issues

Translation - Romanian language

I want to contribute with Romanian translation
ro.zip

Wrong translation when number passed in first field following 4 asterisks.

Any number value passed to first field gives translation "Once an hour".
Example: 756 * * * *, 659 * * * * ...
That is wrong.

It should only accept numbers 0-59 and output should be 'At minute 0' - 'At minute 59' .

FR expression error

Hi,

I think there is a mistake in one of the french translation of the crons. When a cron expression return "times per day", it says two times the word "fois" in french.

Example :
This cron expression : 00 2,8,14,20 * * * returns "4 fois fois par jour" when it should be "4 fois par jour"

I think the mistake is with your "times" array in lang/fr/times.php :

return [ 'default' => ':number fois', ];

Mixed with your "times_per_day" key in the "hours" array in lang/fr/fields.php :

'times_per_day' => ':times fois par jour',

Next run

Is only an idea but can be interesting to add two methods: one to validate valid(): bool and one to determinate the next and previus run. What do you think?

Hi, there is such a cron:
*/15 0-8,21-23 * * *
And i get the error:
Failed to parse the following CRON expression: */15 0-8,21-23 * * * {"userId":205,"exception":"[object] (Lorisleiva\CronTranslator\CronParsingException(code: 0): Failed to parse the following CRON expression: */15 0-8,21-23 * * * at /var/www/vendor/lorisleiva/cron-translator/src/CronTranslator.php:33)
How to fix it?
On https://crontab.guru/ such this cron is recognized...

Many open PR's

There are many PR's open that are just translations, I think these people deserve a reaction on their effort to improve this library.

Can I help somehow to check (and maybe pull) the PR's.

How to check if the command is valid?

Is there a way to find if the specified command is valid, before translating it?

Translation support

Hi @lorisleiva
Thank you for the package!
I'm wondering, would it be possible to add translations support?

Undefined property: DaysOfMonthField::$expression

<?php
 
 class DaysOfMonthField extends Field {
 
     public $position = 2;
 
     /**
      * @throws CronParsingException
      */
     public function translateEvery() {
         **if ($this->expression->weekday->hasType('Once')) {**
             return $this->lang('days_of_week.every', [
                         'weekday' => $this->expression->weekday->format(),
             ]);
         }
 
         return $this->lang('days_of_month.every');
     }

Support for @reboot and others

Would the @reboot and other be supported in future?
string meaning @reboot Run once, at startup. @yearly Run once a year, "0 0 1 1 *". @annually (sames as @yearly) @monthly Run once a month, "0 0 1 * *". @weekly Run once a week, "0 0 * * 0". @daily Run once a day, "0 0 * * *". @midnight (same as @daily) @hourly Run once an hour, "0 * * * *".

Crontab Man page

It is unable to parse a bit complex ones.

I get the parsing error Failed to parse the following CRON expression: 0 9 1-7,15-21 * 1

A good example is a bi-weekly cron expression which is also fairly common => 0 9 1-7,15-21 * 1 see it here crontab.guru .

Incorrect description on ranges/fixed time elements

While this may seem human readable it actually simplifies it too much.
1-5 for hours does not mean 5 times a day as that would imply its spread out over the whole 24 hours ie 4,8,12,16,20,0. Same applies for the mins/days/months etc. Its can actually be very misleading.

0 1-5 * * * would be better represented as Hourly between 1-5am
0 1-5,12 * * * would be better represented as Hourly between 1-5am/12pm
0 1-5,12 * * * would be better represented as Hourly between 1-5am/12pm

CronTranslator::translate('0 1-5 * * *');     // => 5 times a day
CronTranslator::translate('0 1 1-5 * *');     // => 5 days a month at 1:00am

lorisleiva / cron-translator Goto Github PK

cron-translator's People

Contributors

Stargazers

Watchers

Forkers

cron-translator's Issues

Recommend Projects

Recommend Topics

Recommend Org