lorenzofox3 / smart-table-website Goto Github PK

View Code? Open in Web Editor NEW

18.0 11.0 91.0 2.87 MB

documentation website for smart table

JavaScript 69.46% CSS 4.88% HTML 25.66%

smart-table-website's Introduction

smart-table-website

documentation website for smart table

smart-table-website's People

Contributors

Stargazers

Watchers

Forkers

dralexmv lee-elenbaas thandunaresh stephanhoyer flopap andhr3y wmbutler izaakrogan sravankumar-iep krishnasai123 hazeledmands divyang4481 tb adarshk7 miseru ianhd ydench nmalacarne aeharding bobyenser ivahaev anbarsan1 xorionrtm lucky-men atheohar devmark kmcswiney djakaria21 diogocarvalhoti hheexx shareefpns fjljenny julienitard lookfirst eirikbell postelrich sali1982 vardung bernfarr nuntas ebrahim-hamdy complotto aspone juliansk vigucool swatikiran123 veni123 pushpa33 igorlino rodrigoroma mjsgreen01 zvikaz joelbear5 ajaytyagi90 dougdomeny figo050518 brendanoffer georules wangpei24 opencst ojraqueno neeturs doraeball22 athiradandira tonyeven csw1221 renato2016 loveyourselfgirl engpetershaker thirusthiru kailushan4 meronabrha floriniacob akashnanobi johntiger1 saravananrmade sureshnegi rodriglu ismchall fasla luluhow eslam-abdelbaset crazylijo8 wolfxu1981 vijitha-paragon parasgarg11 snamburi3 thejacksonlaboratory jocassid fozersahin kangame2000

smart-table-website's Issues

stSearch Documentation Correction

In various places in the documentation it appears that the value of st-search is a string. But in reality it should be an expression that evaluates to a string.

I would update the documentation and submit a PR, but the documentation is missing.

Example:

Change this:
<input st-search="firstName" placeholder="search for firstname" class="input-sm form-control" type="search"/>

to this:
<input st-search="'firstName'" placeholder="search for firstname" class="input-sm form-control" type="search"/>

subtle change. Added single-quotes around the firstName key.

Sort documentation should include classes: st-sort-ascent, st-sort-descent

Hi Lorenzo - absolutely great job on smart-table!! One minor revision to the sort documentation - include a description of the st-sort-ascent and st-sort-descent CSS classes.

Best,

Brian Cummings

stSearch and stSelectRow not working well together

Hi Lorenzo,

Just found that when combining stSearch and stSelecteRow an error is generated:

Error: [$compile:ctreq] Controller 'stTable', required by directive 'stSelectRow', can't be found!

Code looks like:

<table st-table="dataCollection" st-safe-src="dataSource" class="table table-striped table-bordered">
    <thead>
        <tr>
        <th colspan="3">
            <input st-search="" class="form-control" placeholder="Filter..." type="text"/>
            </th>
        </tr>
    <tr>
        <th st-ratio="20" st-sort="Column1">Column 1</th>
        <th st-ratio="50" st-sort="Column2">Column 2</th>
            <th st-ratio="30" st-sort="Column3">Column 3</th>
        </tr>
    </thead>
    <tbody>
        <tr st-select-row="row" st-select-mode="single" ng-repeat="row in dataCollection" ng-click="setSelection(row)">
            <td>{{ row.Column1 }}</td>
        <td>{{ row.Column2 }}</td>
        <td>{{ row.Column3 }}</td>
        </tr>
    </tbody>
</table>

This only happens if the input filter is filtering the dataCollection. Do you have any idea why this happens, or is this a know issue?

Thanks in advance.

Jeroen

Default bootstrap template for pagination has wrong mark-up

The default pagination template is currently this:

<div class="pagination" ng-if="pages.length >= 2"><ul class="pagination">...</ul></div>

Due to ul.pagination being nested in div.pagination, there's double margins, which looks bad.

The default Bootstrap example uses this markup:

<nav ng-if="pages.length >= 2"><ul class="pagination">...</ul></nav>

I have overwritten the template in my own app, but I think it's good to fix the default in this library as well.

Memory leak

Hi,

This is great angularjs table. Nice work!

I am facing huge memmory leak when i used the samrt table in phone gap hyrbrid application.RAM usage of Android application huge. I am using multiple smart tables in single page.RAM usage is increasing after each root change.Please help me to solve this issue

Doc Correction

Fix header & custom pagination has the same heading as below:

"smart-table with fix headers and responsive layout, pure css solution"

Request to correct.

st-sort-default needs to have a non-empty value for ascending

For default sorting, simply doing <th st-sort="myProperty" st-sort-default> will not sort the data by that column. If I do st-sort-default="reverse", that correctly sorts in reverse. As a fix, I tried doing st-sort-default="whatever" and that did the trick. It doesn't seem to matter what value is used, just as long as it's provided and it's not "reverse" for the default ascending order.

Hash Link Failure

The intrasite hash links work when clicking a link on the site, but they don't seem to work when following a link from outside of the site or when refreshing the page. For example:

http://lorenzofox3.github.io/smart-table-website/#/section-filter

Column Filtering

There seems to be something missing with the filter section of the documentation. There's a directive defined in app.js that needed to be included in my code before the column filter would actually work. This isn't referenced in the documentation.

Am I correct about this? If so, I can submit a pull request to amend the documentation with that info.

Wrong directive spelling

Hi,

Thanks for that directive, best of all the ones I've tried :-)

I think there's a spelling mistake for the stInputEvent directive declaration:

Current:
select stInputEvent="change"...
Should be:
select st-input-event="change"...

Cheers,
Greg

Ordering with more than one ordering function doesn't display change active row

http://plnkr.co/edit/oIhw5Nsv806wYkXCOfpE?p=preview
In example please click on "last name" header. As expected table is sorted but visual active sort column is "first name". And if i click on "first name" table is sorted by "first name" but in Desc order.

wrong word

This is were you use the stSafeSrc attribute

The were should be where

Pagination not working

Pagination is not working, I'm using Angular1.6.5

Doc error

https://github.com/lorenzofox3/smart-table-website/blob/gh-pages/index.html#L1001

is not shown. tested on chrome.

Does the branch master and gh-pages isn't syncronized?

How to add multiple class in cellClass property

Hello,

I need to add two classes in cellClass property. How would i do that ? Is that functionality already provided ? Though I was not able to find it , I am creating issue.

thanks

Infinite scroll with fixed headers

Is infinite scroll possible while using fixed headers? If so can I see an example?

In the examples, all I see is how to do fixed headers, then how to do regular infinite scroll separately.

to the st-sort

when sort the column, it that possible show a waiting spinner? after sorting is done, the hide the waiting spinner.

because some sort take longer time.

Paging in pipe example

On this line:
https://github.com/lorenzofox3/smart-table-website/blob/gh-pages/sections/pipe/markup.html#L168

It currently has st-item-by-page="10". Should be st-items-by-page="10". Notice the missing s. If I run the current example, the attribute is not recognized and its value is ignored. I tried setting it to 5, for instance, and paging still skipped 10 at a time. Spent a while trying to figure out why. I eventually looked at other examples to figure out the attribute name was a typo.

"Random" errors on iOS

When we access our webapp which includes smart-table, on iOS-based devices, we intermittently get these errors:

angular.min.js:89:239

Are there any known issues with smart-table on iOS?