Giter Club home page Giter Club logo

bagginses's Introduction

Metrics

bagginses's People

Contributors

aktheknight avatar algorithmx2 avatar galaxy2alex avatar guro2 avatar gwyog avatar lorddusk avatar mazdallier avatar nabijaczleweli avatar snowshock35 avatar wescook avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bagginses's Issues

whitelist=false config option not working

Changed whitelist=true to whitelist=false but none of the bags show up. With the config still on set to false I added a item and the bags I added the item to in the configs showed up but only that item would be allowed in, instead of only item not being allowed in.

Version
Minecraft 1.9.4
Bagginses 2.4.2

[1.10.2] [Feature Request] Keybinding for opening bag also closes it

Hello,

I have a small feature request in mind for Bagginses.

The feature is that pressing the key.OpenBag button when a bag gui is open would then close the gui. I suggest this feature as it follows along with set 'Standard' that Minecraft have across other in game GUIS.

I hope you find my feature request valid enough to add it.

Thanks again for the awesome mod and the continued maintenance of it. โค๏ธ

Exception when breaking blocks, this log was generated when using a TIC Hammer.

[Server thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.world.BlockEvent$HarvestDropsEvent@5ed82490:
java.lang.NullPointerException
at nl.lang2619.bagginses.event.ItemDropEvent.onBlockDrops(ItemDropEvent.java:50)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_278_ItemDropEvent_onBlockDrops_HarvestDropsEvent.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:68)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:159)
at net.minecraftforge.event.ForgeEventFactory.fireBlockHarvesting(ForgeEventFactory.java:213)
at net.minecraft.block.Block.func_180653_a(Block.java:545)
at net.minecraft.block.Block.func_176226_b(Block.java:537)
at net.minecraft.block.BlockReed.func_176353_e(BlockReed.java:116)
at net.minecraft.block.BlockReed.func_189540_a(BlockReed.java:105)
at net.minecraft.block.state.BlockStateContainer$StateImplementation.func_189546_a(BlockStateContainer.java:463)
at net.minecraft.world.World.func_180496_d(World.java:517)
at net.minecraft.world.World.func_175685_c(World.java:466)
at net.minecraft.world.World.func_175722_b(World.java:421)
at net.minecraft.world.World.markAndNotifyBlock(World.java:366)
at net.minecraft.world.World.func_180501_a(World.java:347)
at net.minecraft.block.Block.removedByPlayer(Block.java:1106)
at net.minecraft.server.management.PlayerInteractionManager.removeBlock(PlayerInteractionManager.java:275)
at net.minecraft.server.management.PlayerInteractionManager.func_180237_b(PlayerInteractionManager.java:333)
at net.minecraft.server.management.PlayerInteractionManager.func_180784_a(PlayerInteractionManager.java:220)
at net.minecraft.network.NetHandlerPlayServer.func_147345_a(NetHandlerPlayServer.java:631)
at net.minecraft.network.play.client.CPacketPlayerDigging.func_148833_a(SourceFile:40)
at net.minecraft.network.play.client.CPacketPlayerDigging.func_148833_a(SourceFile:10)
at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)

MC1.10.0 version no block drops

Added Bagginses-1.10-3.0.0 to my world, now, no blocks will drop when mining.
Set B:"Should bags be able to pick up items when dropped"=false, no change.
Set B:whitelist=false with no change.
Added a bag name in the json file with no change.
Put a bag in my inventory and chopped down a tree. No blocks in inventory or the bag.

No blocks drop when mining them. First noticed with a tree, got no wood blocks, then tried to mine dirt, nothing dropped. Also breaks the mod Veinminer. Tried Bagginses with and without veinminer with the same results.

can't config

You say to config if you don't see bags ect. I am using 1.9 and your latest 2.3.0b however when I go to the mod options I can't seem to config the button is there but there is nothing to config.

Allow renaming of bags in configuration file

It would be useful to allow renaming of the bags in the configuration file, or add a custom description. That way it is easy to know which bag does what without requiring displaying all items in whitelist.

[1.9.4] Crash Shift cliking items onto the Void Bag

Using version Bagginses-1.9.4-2.4.2b when I shift click items into the Void Bag, the mod crashes.

[15:37:55] [Client thread/FATAL]: Reported exception thrown! net.minecraft.util.ReportedException: Updating screen events at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1712) ~[bcd.class:?] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1056) ~[bcd.class:?] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:369) [bcd.class:?] at net.minecraft.client.main.Main.main(SourceFile:124) [Main.class:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_77] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_77] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?] at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_77] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.8.0_77] at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_77] at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:310) [NewLaunch.jar:?] at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:395) [NewLaunch.jar:?] at org.multimc.EntryPoint.listen(EntryPoint.java:170) [NewLaunch.jar:?] at org.multimc.EntryPoint.main(EntryPoint.java:54) [NewLaunch.jar:?] Caused by: java.lang.NullPointerException at nl.lang2619.bagginses.references.BlockList.contains(BlockList.java:45) ~[BlockList.class:?] at nl.lang2619.bagginses.items.bags.container.BagContainer$SlotBag.func_75214_a(BagContainer.java:271) ~[BagContainer$SlotBag.class:?] at nl.lang2619.bagginses.items.bags.container.BagContainer.tryShiftItem(BagContainer.java:172) ~[BagContainer.class:?] at nl.lang2619.bagginses.items.bags.container.BagContainer.transferVoid(BagContainer.java:147) ~[BagContainer.class:?] at nl.lang2619.bagginses.items.bags.container.BagContainer.func_82846_b(BagContainer.java:136) ~[BagContainer.class:?] at net.minecraft.inventory.Container.func_184996_a(Container.java:258) ~[aau.class:?] at nl.lang2619.bagginses.items.bags.container.BagContainer.func_184996_a(BagContainer.java:231) ~[BagContainer.class:?] at net.minecraft.client.multiplayer.PlayerControllerMP.func_187098_a(PlayerControllerMP.java:540) ~[bkr.class:?] at net.minecraft.client.gui.inventory.GuiContainer.func_184098_a(GuiContainer.java:630) ~[bfr.class:?] at net.minecraft.client.gui.inventory.GuiContainer.func_73864_a(GuiContainer.java:389) ~[bfr.class:?] at net.minecraft.client.gui.GuiScreen.func_146274_d(GuiScreen.java:540) ~[bez.class:?] at net.minecraft.client.gui.GuiScreen.func_146269_k(GuiScreen.java:509) ~[bez.class:?] at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1699) ~[bcd.class:?] ... 17 more

I was shift clicking 1 stack of spruce wood planks

PS: Any item you try to place on the void bag, crash the mod.

[1.10.2] [Bug] Localization undefined in option's controls menu

Hello,

I believe to have found a minor bug with Bagginses, here are the details of my issue:

Important Information

  • Minecraft 1.10.2
  • MinecraftForge 12.18.1.2071 (Latest as of reporting
  • Bagginses 3.0.4a (According to ingame mcmod.info file)

Issue Description

The issue is very minor. A keybinding was recently added to the mod in order to open bags by pressing a button however, localization for the Options/Controls menu was forgotten. (A Pull Request will be submitted to fix this issue.)

Issue Media (Screenshot)

Issue Media No. 1

[1.10.2] bug with metadata in pickup mode

bagginses 3.0.3
tinkers construct 2.4.0-jenkins 312
forge 12.18.1.2046

not a game breaking bug, with the bag in pickup mode, when you break the first casting basin or a casting table, it will go to the bag, but the subsequent ones will be converted to the first one breaked indiferently to what one it was
a few pics to try to explain better
http://imgur.com/a/YYome
edit: forget to activate F3+H, but it has the same item ID, but one is /0 and the other is /1(forgot what the name of that tag )

edit time: so, it seems that it can mess anithing that uses metadata, storage drawers for example(sealed for transport and forgot to deactivate the mode) so it can become a realy game breaking if used in some combinations, like putting a nether star in a drawer, seal it with a paking tape break first, seal a bunch of drawers, break, repeat. it can break ic2 and substratum oregen, as these mods utilize metadata for its ores.

[Feature Request] Achievements

Hi,

I'd like to make a feature request for Bagginses. Here it is...

What is the suggestion?
To have various achievements for the mod e.g. Bag crafting, upgrading etc.

How would you go about doing this?
Use standard Minecraft achievements and add them in with some code -- I'll leave you to figure that out ๐Ÿ˜›

Why?
Because why not! Also, adds a sense of well-polished mod

Hope you like the suggestion and consider adding it your awesome mod

Easier Inventory/Bag Transfer

On the newest version (2.0.1) and there isn't shift-click support into the bag (out of bag works though) and I can't space-click everything into there (forget if that's vanilla, NEI, or inv tweaks ability). There is also no inv tweaks sorting in the bags.
Would it be possible to add those things? (Shift-click support, might be a bug in this version?; Space-click/Inv Tweaks support)

Tier 2 Bag disappears when used

Took a little bit of work, but I found out where the bag breaks. If you want to craft a tier 2 bag and try to shift click it to finish the crafting, it will flicker for a second. Any attempts to shift click move the bag will result in nothing happening. Pulling the bag out by clicking on it normally will move it, but the bag will disappear when used. This issue persists; any tier 2 bag that is crafted will disappear when used, regardless of whether or not you shift clicked it. The only way to fix this is to remove the mod, load up Minecraft, quit, and put the mod back in.

Running version 1.1 of Bagginses.

No chat output when changing modes

I crafted a tier 3 white bag and used shift-right click to change the mode. No chat message showed up, and this error was put in the server log:

http://pastebin.com/GgKLstct

Using version 1.10-3.0.3.

Full server log:
https://gist.github.com/6ff20842f147764469f386cdfa13465a

latest.log:
https://gist.github.com/fa4b77079f44ac191b41fbf6982c970c

Forge version: 12.18.1.2065.

Steps to reproduce:

  1. Hold baggins tier 3 bag in a hotbar slot.
  2. Right click.
  3. Examine server output for error message.

What I expected:

  • Messages saying the mode had changed.

Dupe bug

Hey, it seems that it's still possible to duplicate items using the number hotkeys:

Gif

Here's what I did:

  • Have two stacks in the bag
  • Use the number keys to move one stack to the slot where the bag is, moving the bag into another slot
  • Grab the bag and shift-click on the other stack so it lands in the inventory
  • Throw the bag out of the gui

When you now pick up the bag it still contains a stack.

Version used: 2.1.5b

Bag contents overwritten

Using v1.2.1 in the Regrowth modpack. I had two bags on my hotbar, a white tier 2 and a yellow tier 2. I went out exploring and found a hive, so I went to open my white bag, and it wouldn't open, then my world showed signs of temporary lag. The bag then kicked open and showed the contents of yellow bag (which was three foodstacks and clay jars.) All of my tools (white bag) were now erased and replaced.

Config resets client side after update.

Why would you disable the loading of the block via config option?
If a server who hosts a pack with your mod now decides to disable bags or just colors.
Clients who do not have the exact same config options can not join the server.
Why not just disable recipes/ nei or jei appearance?

In the latest version of 1.9.4 this a huge issue. The config resets every time I updated the mod clientside. I forgot 1-2 times to change the said config. Uploaded my updated pack to curse via export just to find out, that clients cannot connect to the server because the configs did not match.

A config should be set serverside and then supplied to clients if nesseary. In this instance it should not even be nessesary.

[Feature request] Bag recoloring

Allow crafting a with a (please, please use OreDictionary for this - don't be evil like certain other modders!) to change the bag color to 's color.

Duping from bags.

I know this is an issue and I'm working on it. Please don't make more issue tickets about this.

[Feature Request]-Dump bag inventory to chests

Hi Dursk,

Another feature request for bagginses here. It would be awesome if you could shift right click the bag onto a chest to dump the items in it and maybe have it so only tier 2 can do this maybe :/ dun know just a thought I had ;)

v2.0.2 Bag Bug

It seems that only the void bag is available. I uninstalled the mod and the only thing missing from the world was bagginses:void.

crash when opened creative tab and mouse over bag icon

[B#347] Description: Rendering screen
[B#347]
[B#347] java.lang.NullPointerException: Rendering screen
[B#347] at nl.lang2619.bagginses.items.bags.Bags.func_77624_a(Bags.java:91)
[B#347] at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:588)
[B#347] at net.minecraft.client.gui.GuiScreen.func_146285_a(GuiScreen.java:130)
[B#347] at net.minecraft.client.gui.inventory.GuiContainerCreative.func_146285_a(GuiContainerCreative.java:679)
[B#347] at net.minecraft.client.gui.inventory.GuiContainer.func_73863_a(GuiContainer.java:166)
[B#347] at net.minecraft.client.renderer.InventoryEffectRenderer.func_73863_a(InventoryEffectRenderer.java:51)
[B#347] at net.minecraft.client.gui.inventory.GuiContainerCreative.func_73863_a(GuiContainerCreative.java:590)
[B#347] at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:312)
[B#347] at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1094)
[B#347] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1072)
[B#347] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:366)
[B#347] at net.minecraft.client.main.Main.main(SourceFile:124)
[B#347] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[B#347] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[B#347] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[B#347] at java.lang.reflect.Method.invoke(Unknown Source)
[B#347] at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
[B#347] at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Change the config file to use a blacklist rather than a whitelist.

The config file uses a whitelist to dictate which bags can hold what types of items, with support for specifying mod names. This is cumbersome for the most general use case, which is to whitelist every item. It would be better, at least in my opinion, to change the config file to use a black list. Then modders could blacklist items that cannot appear in bags or if left blank (as is the default), bags will be able to hold any item.

Another possible solution to this problem would be to add a single global boolean config option to whitelist all items for all bags.

3.0.0b crash when mousing over bag in JEI

When hovering mouse over any bag in JEI, get an ArrayIndexOutOfBoundsException: 1 error. Thought it might have to do with naming bags, but it crashed even hovering over a named bag. The rest of the error.
Version 3.0.0a does not have this error.

at nl.lang2619.bagginses.items.bags.Bag.func_77624_a(Bag.java:130)
at net.minecraft.item.ItemStack.func_82840_a(ItemStack.java:610)
at mezz.jei.gui.ingredients.GuiItemStackFast.getTooltip(GuiItemStackFast.java:216)
at mezz.jei.gui.ingredients.GuiItemStackFast.drawTooltip(GuiItemStackFast.java:209)
at mezz.jei.gui.ItemListOverlay.drawTooltips(ItemListOverlay.java:348)
at mezz.jei.GuiEventHandler.onDrawScreenEventPost(GuiEventHandler.java:109)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_404_GuiEventHandler_onDrawScreenEventPost_Post.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:68)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:159)
at net.minecraftforge.client.ForgeHooksClient.drawScreen(ForgeHooksClient.java:375)
at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1094)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1076)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:371)
at net.minecraft.client.main.Main.main(SourceFile:124)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)

Only Void and Ender bags...

So I just started modding my minecraft and these are the only two bags i can see, i can also so the bag upgrade but not the bags themselves... Bagginses-1.10-3.0.1a

[1.2] Duplication bug

While a bag is on the hotbar and open, the number hotkeys can be used to swap the position of the bag in hand with another bag in the inventory.
Eg, bag in hotbar slot 1, opened. second bag in inventory. Player presses '1' on their keyboard while hovering over the second bag and the two swap positions.
When doing so, the contents of the first bag will be replicated in the second, though only if the contents had been present when the bag was opened. Items placed in since the bag was opened but before the bags were swapped will be placed in the second bag rather than the first.
It's a minor issue in a very niche situation, but unfortunately it was brought to my attention by a user of my modpack posting it publicly in the FTB forums thread.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.