Giter Club home page Giter Club logo

loopring-wallet-feedback's People

Contributors

adam-bro avatar adamchen0510 avatar dong77 avatar mfinestone avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

loopring-wallet-feedback's Issues

Loopring wallet charging crazy fee

Hi;
I'm clearly doing something wrong or there is a crazy bug. Tried to create a wallet. It wanted me to scan a QR code to pay the 42 LRC. I initiated the transaction but when it got to Metamask it wanted a fee of 41 ETH to proceed.

Add additional Withdrawal confirmation screen and warning.

A number of users are Withdrawing assets from L2 to L1 and in particular exchanges. However some users are mistakenly sending from L2 to L2 of exchanges and other users.

An additional warning and confirmation screen should be added to highlight the sending:
From Loopring
To Lx Address
Confirmation of fee

Note: Please ensure for withdrawals to exchanges that the exchange accepts deposits from Smart Contract Wallets and you have checked you are sending to the correct L1 or L2 address of the recipient.

After this screen. The below should be Next and then the above Confirm.

loop

Loopring wallet seems to allow invalid ens names (underscore)

I created a loopring account/address via loopring wallet on iOS, which said for the name / address I had to give a minimum amount of characters and that underscores were allowed. The set up worked and the wallet works. But other apps etc do not recognized the domain as ens domain, but as invalid, as underscores are seemingly not allowed.

LPs earning 0.2%

In 'Utilize: AMM Liquidity' section, at top, it says "Provide liquidity to earn a 0.20% trading fee from every swap." Should say, "0.20% per swap is distributed among liquidity providers (in proportion to pool share)."

I was going to put a similar comment in the DEX section here on GitHub but I don't see one. For exchange.loopring.io, in both the 'Swap' and the 'Pool' sections, would change the wording about the liquidity provider fee there as well. I think the wording should be clearer. Would use same wording as recommended above.

Orderbook historical orders

It would be better if the filter would stick. I don't want to see eg cancelled orders, but I have to apply the filter every time I get back into that screen.
Thanks

Emptying the wallet is currently impossible

I report the extract from a dialog with "odesium" in Discord.

At the moment of writing a user cannot fully empty the wallet (tested in L1) of all currencies.

While sending the whole amount (press all out) of ETH/DAI etc. the smart contract accounts for the maximum possible fee while normally it's much lower. This implies that no matter how low fees are or how much money one has in the wallet, there will always remain a residue due to the Smart C. inflated prediction.

User Agreement 404 Errors

Under "User Agreement"

  • the Privacy Policy hits a 404 error (on githib)
  • the Terms hits a 404 error (on github)

Points program unannounced changes or failures

When I created a Loopring wallet the points program was explained such that points were pegged 100:1 with USDT and that they would be able to be used to cover some fees within the app. As it stands now, points are only able to be used when transferring in the L1 -> L2 direction within the app and nothing else. They have also lost their peg and are currently valued at 1 Point = 0.004237 USDT (that's what it says on the Points page) which is 236:1 with USDT.

I feel they should at least be able to also be used when transferring L2 -> L1 within the app and the peg should be restored, but adding additional use cases (adding/removing liquidity) could also be beneficial to incentivize use of the Loopring protocol

Translation incomplete

This is likely a known issue, just putting it here for tracking ..

under "settings" ... Daily Quota is described as, "Not as no limit" .. just a bad translation. Should be "Has no limit"
Also : User Feedback page is still in Chinese. needs to finish being translated.

List of near term questions for Nov 27th

Does the Loopring guardian count as one of the 3 needed for the mining bonus? (Shadon)

Can you have the same Loopring wallet on 2 phones? By recovering it on the send device, does it lock first? (Matheus)

Should I send all my assets to L2 or will I have to bring them back to L1 for the update on the 27th? i.e. Can I migrate to 3.6 from L2 to L2 within the wallet, or must withdraw first, and spend gas?

Display/Filter issue - L1

L1 slider bar/filter : selecting "remove Tokens less than $1, and "remove Token without price" broken ... selection makes no change.
This function works correctly under the L2 slider bar (tokens are removed form view)

Confusion around adding Metmask/Walletconnect Guardians

Users are struggling to add non-loopring wallet guardians. Here's what they're doing:

Step 1
They are scanning/adding non-loopring wallets in the guardian search feature
ios adding guardian search

Waiting for guardians approval
Waiting for guardian's approval

Step 2
Users go to security.loopring.io to add the guardian and it fails
security loopring io

Change iOS text
Can the iOS copy match the Android copy. iOS is not as clear
20210618_171936

Possible Solution
Add another button which takes you to an instruction page.
Adding Guardian 1
Add guardian 2

From User: Allow users to withdraw funds leaving zero balance.

Due to the max gas estimate, user cannot withdraw all funds from wallet without leaving residual balance of gas fee.

From User:
when I try to send from the app (or even MEW) it says I can't because I need 0.0435 ether or equivalent. If that's the fee it's around 76 dollars which is simply too high!
I simply want to empty my wallet (inside I have roughly 40 dollars) but I'm not allowed to do it.
So the thing is: my funds are stuck inside until gas fees are (hopefully) lower.
While I'm here I'm signaling this. Before having roughly 40 dollars I had more, I moved them (pressing "All out" when the app demanded how much I wanted to transfer) but for some reason those 40 remained back. I suspect it's a miscalculation of the fee, or maybe the smart contract keeps the maximum possible while generally the required is lower. Sincerely I have no idea.
What I understand is, probably even if fees were lower I would have the same problem (I can never completely empty my wallet, no matter how much I try to empty it) with a (each time) lower residue.
I have no idea how Metamask or Argent (if we are talking about custodial, smart contract based, wallets) allow to completely empty the wallet in one shot.

Add Guardian Page : Whitespace bug

pressing on the empty white space on the "Add a guardian page" (empty white space between the back arrow and QR code scanner .. above the enter address field) brings you to the "invite new users now" screen ... probably not supposed to do that.
if that page is erased, that white space could cause a possible exception or fault? who knows ... but probably not expected/predicted behavior

User control of setting gas fee

Some users have expressed they want to be able to pay a lower gas fee to go from L1 - L2, if they are not in a rush, and don't want to pay so much gas. They cannot adjust it currently.

image

or even the ability to have two types, similar to fast withdrawal mechanism. to go immediate, or wait for a batch. (unsure if that is feasible for deposits).

image

Wallet balances in $ frequently showing wrong value

A couple users have said that their balances in the app show with incorrect values, which change when refreshing the balances page. It seems to snap to some constant values. Are values still hard coded somewhere that makes it maybe show those values if it's not able to grab the dynamic values?

ux nit: the word transfer is used twice

when I view the eth 1 balance, The word transfer is used twice:

  • one time it means transfer to different L1 address.
  • the second time it means transfer to my own L2 address.

Consider different words? maybe 'Send' for the L1 address?

L1 trade pulls from L2 funds

Not sure if this is expected behavior or not ...

Going to the L1 screen to initiate a trade, and pressing any of the 25/50/75/100% buttons will fill the entire value of both L1/L2 funds.

Also from the L1 trade window, making a trade greater than the L1 account balance pulls all funds from L2 ... opposed to pulling ANY funds from L1 balance.

Email cannot be used again after creation time expiry

From user tjumma:

Hello, guys! I have a problem - yesterday I started creating a new wallet, but my creation time (1 day) has expired, I pressed create a new one to select a different name for it, but the app does not let me use the same email - it says 'The email has been registered before'

-- Is there a solution for this?

Loopring Wallet address : invalid

Getting an error using the Loopring hex address generated during Loopring Wallet creation.

Publish0x is returning an error stating, "Provided address is invalid, please check and try again"

Is this an error with Publish0x? or an issue of the wallet address generation checksum?

Out of Gas

I tried to make and fund a new wallet today. Tried twice, out of gas error for both transactions... finally I set the gas limit high enough on the 3rd one for it to go through. I suggest updating the new wallet deposit notification in app to recommend a specific gas limit. I entered 52000 manually for that 3rd transaction to post, even though I see after making the wallet that the limit only needs to be 23,300.

Unable to transfer LRC tokens from L1 to L2

Info

Loopring L1 mobile wallet currently holds 1000 LRC tokens

Steps to reproduce

  1. Click on L1 account in mobile wallet.
  2. Click on LRC token
  3. Click on L1-L2 transfer button
  4. Enter amount, all 1000 tokens
  5. Click next
  6. Click confirm
  7. Verify identity with biometrics(thumbprint)

Result

Failure notification stating, "Transfer failed, please try again later"

ETH hex addresses not reconized in "Add Guardian"

Trying to add a L1 external ETH address (from another wallet) doesn't work under the 'Add Guardian" page.
Either by manually typing, or using the QR scan.
In both cases, it only shows a 'No Search result" found and is unable to be selected

Explain why we need email/phone number

Many people in crypto are averse to disclosing this info. Let's provide a little explanation as to why we need it, so it comforts them, and they see it is mainly for their own benefit.

I believe the reasons are:

  1. Loopring Guardian. So if they lose access to their mobile wallet before setting guardians, we can help them recover it.

  2. Sybil-resistance. So we don't spin up contracts and waste gas for nothing. (although this is obviously not airtight, since people can spin up email addresses trivially).

Cannot get creation code from email + return to code page

If I exit the wallet to access my email on my same mobile device to retrieve the code, I cannot then return to the page that asks for my code. It returns me as if I never asked for it. So unless you are accessing email on another device - and keeping the code page open on wallet - you are stuck.

钱包有开源么?我看宣传不用私钥和助记词了?

您好,国人就直接中文了。

对于钱包不用私钥和助记词,这个感觉怪怪的。
我想我需要在技术上得到解释,要不然总不会安心啊。

换句话说,我怎么证明我对我的钱包的所有权啊。

sorry to bother.Best wishes.

Unable to add metamask address as guardian

Steps to reproduce:

  1. I navigate to security.loopring.io and choose metamask from wallet connect options, and sign the message.
  2. Click on add as guardian to display QR code.
  3. Open guardian page and choose 'add a guardian' in loopring mobile wallet, and scan the QR code from security.loopring.io.
  4. Enter a name & click Add

Result:

No guardian is added & notification appears, "An error has occurred, pleas try again later"

I have tried this probably 10-20 times, using different metamask accounts and the result is always the same -> an error occurs and no guardian is added.

Wallet creation problem w/ email validation

Having installed the app and created my wallet via email, I went to find some ETH to transfer in.

Unfortunately when I returned I can no longer access the address to transfer funds in, nor create a wallet - because my email is now taken.

Low gas price notification

Can the wallet app add a new feature: User can choose to be notified when the ethereum gas price is low or under certain value. This feature should be good for user to determine when to create a new wallet (more chance to create new wallet when gas price is low), withdraw or deposit.

Red Packets Failing

When trying to send red packets, if I don't click on 0 first, then the red packet app screen closes out.
In addition, if I try to send a packet to the public, I am not able to do so.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.