executeSql should return mssql results about loopback-connector-mssql HOT 5 CLOSED

@ataft, thanks for the suggestion. Your proposal sounds reasonable to me. It's important for us to keep the backward compatibility. @jannyHou, what do you think? Thanks.

from loopback-connector-mssql.

@ataft Thank you for the suggestion and investigation made. 👍

I'd make the PR and clearly it wouldn't affect any users.

And we really appreciate your help on the the code contribution 👍, will review it when ready.
Changing the returned data of executeSQL would affect all CRUD queries, if you only want to configure the result of a native query, I think you need to make the option turned off by default. And better disable it for the built-in CRUD queries.

I checked the sqlServer query runner in TypeORM, and find they also returns the result.recordset by default, sometimes returns the result.affectedRows. Just curious...could you explain more about when the raw data is needed?

from loopback-connector-mssql.

Maybe the term "raw data" is confusing. I mean return whatever object the mssql library returns. The use case is to get rowsAffected or any of the other results:
https://github.com/tediousjs/node-mssql#execute-procedure-callback

Yes, it would clearly be off by default.

from loopback-connector-mssql.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from loopback-connector-mssql.

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

from loopback-connector-mssql.