Comments (7)
Looks like it's the same with looks like it's the same with [email protected] so maybe the oracle connector is the exception here.
IMO, it'd be helpful if the connector is exported so that we can extend the functionality.
from loopback-connector-mssql.
@b-admike @jannyHou, looks like we export Oracle
in https://github.com/strongloop/loopback-connector-oracle/blob/master/lib/oracle.js#L105. Do you think it makes sense to export it?
If so, @Pollocks01, would you be interested in submitting a PR?
from loopback-connector-mssql.
@dhmlau I've never done that before.
I wish I knew more about the GIT process and had time to get involved: my employer's still on SVN, trying to move to GIT :-)
from loopback-connector-mssql.
@dhmlau It makes sense to me to export it for a better extensibility.
cc @raymondfeng in case there is any security concern.
from loopback-connector-mssql.
@Pollocks01, let's wait for the response from @raymondfeng (who is on vacation currently), in case there's a particular reason not to export.
In the meanwhile, we've updated our instruction to submit PR in our docs: https://loopback.io/doc/en/contrib/code-contrib.html#submitting-a-pull-request. There's a pretty good article for first-time contributor: https://www.nearform.com/blog/getting-into-open-source-for-the-first-time/. Hope it will help you in the future for submitting PRs in github. :)
from loopback-connector-mssql.
@Pollocks01, sorry about the late reply. Talked to @raymondfeng , he's good with exporting MsSQL
. Would you like to submit a PR? Thanks!
from loopback-connector-mssql.
@dhmlau Thanks for the update. As much as I'd like to be, I'm not currently an active contributor and really don't have the bandwidth to take that on right now.
I'll submit a PR in the future and refer to this one if I'm able to do so. The same would be required on some other database clients too. I think for PostGres, for example too.
thanks
from loopback-connector-mssql.
Related Issues (20)
- tedious type deprecation messages in console HOT 2
- query the table using rowversion HOT 2
- AutoUpdate needs to have order when executing index related operations HOT 2
- Loopback 4 relations compatibility HOT 15
- applyPagination is missing the ORDER BY clause when supportsOffsetFetch HOT 2
- loopback 4 model options not working for mssql HOT 5
- Incorrect Table Relations Discovery HOT 5
- Relations not working in loopback 4 using mysql database How to solve it HOT 3
- Run shared tests from both v3 and v4 of juggler
- Transaction not working in Loopback 4. HOT 2
- New release? HOT 2
- Loopback 4 Transaction returning undefined. HOT 8
- EPERM on version 3.7.0
- EPERM in version 3.7.0, error related to adal node package HOT 22
- executeSql should return mssql results HOT 5
- Loopback 4 can not parsing javascript Date Object to native SQL statement which require Date parameter HOT 1
- migrate script not supports custom column names
- Having CVE in the current version. can you please update to latest version of mssql and loopback-connector HOT 1
- Like operator not working when trying to fetch stringify array of objects or object
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from loopback-connector-mssql.