The kohana-notice from loonies

kohana-notice's People

Contributors

Stargazers

Watchers

kohana-notice's Issues

add array as message parameter in add function

Hi, thanks for this simple little module. it's very useful.
I would like to request to add array as message parameter in add function so you can pass array in message parameter.

This is useful when we want to render error from validation class (which resulting array)

for example

Notice::add(Notice::ERROR, $validate->errors('items'));

so the code need to updated to something like this

/**
 * Adds new notification message
 *
 * @param   string  Message type
 * @param   mixed   Message text or array of Message text
 * @param   array   Message variables
 * @param   array   Additional message items
 * @return  void
 */
public static function add($type, $message = NULL, array $variables = NULL, array $items = array())
{
    $session = Session::instance('native');

    $notifications = $session->get('notice', array());

    if (Arr::is_array($message))
    {
        foreach ($message as $value)
        {
            $notifications[$type][] = array(
                'message'   =>  __($value, $variables),
                'items'     =>  $items,
            );
        }
    }
    else
    {
        $notifications[$type][] = array(
            'message'   =>  __($message, $variables),
            'items'     =>  $items,
        );
    }

    $session->set('notice', $notifications);
}

Thank you

Session shouldn't force driver

In Notice Core, the session driver is forced to native.
This need to be changed to

$session = Session::instance();

The reason

When developing using database session driver, we don't need to set native driver session cookie name.
This should be controlled by user not by module.