logicalparadox / folio Goto Github PK

As the module sits right now, the call to .root(__dirname, '..') will result in:

path.js:7
    throw new TypeError('Path must be a string. Received ' + inspect(path));
    ^

TypeError: Path must be a string. Received [ '<path>', '..' ]

The fix is:

Glossary.prototype.root = function () {
  const args = Array.prototype.slice.call(arguments);
  this._attrs.root = path.resolve.apply(path, args);
  return this;
};

We're distributing the compiled chai.js in Konacha, and we're getting massive diffs, presumably because the ordering of the included files is random. I'm assuming that

.dir('./lib')

is the culprit. I can't find the right place in folio to fix this, but IMO it could and should just sort everything alphabetically, rather than relying on file system order.

I am having some troube when minifying with folio 0.2.x ( i am not using 0.3.x because your advice)

The problem disappear when upgrading Uglify-js from 1.2.x to 1.3.x

I have forked your project beacause of that ( i cant pullrequest to your tag 0.2.1 tag, i think you need to have a branch for that)

Anyways my branch
https://github.com/inaes-tic/folio/tree/newer_uglify