logentriescommunity / le_php Goto Github PK

Hi!

I'm currently integrating logentries into our application. The current released version is 0.6, but I can't really find anything about:

1. What's left to do to declare it "1.0"
2. In what ways we can expect the API to change
3. Any sort of commitment around API stability (e.g.: will upgrading to 0.6.1 be safe, what about 0.7.0 or 1.0?)

Can you share any documentation about this?

The constants defined in LeLogger.php has been set to api.logentries.com, but the documentation (https://logentries.com/doc/input-token/) says that the address should be data.logentries.com.

I guess that this needs to be changed, both for TCP and TLS?

I noticed that logentries by default is a singleton. This is handy, but for my situation I would prefer to open a number of sockets so I can connect with multiple channels.

Could we make the constructor public but keep the tcp socket as static? This way we can reduce the sockets, but maintain the ability to post logs to multiple channels.

Please use predefined contants, see:
http://php.net/manual/en/network.constants.php and http://www.ietf.org/rfc/rfc3164.txt (sec: 4.1.1)

Relying on global variables is considered a bad practice in PHP. It would be best not to promote or suggest using this.

You have a fairly decent API in LeLogger.php, but promoting the API in lelogger.php is something I would suggest you avoid.

Rather than making it 'the API' it may be better to show it off as an example that can be re-used, but shouldn't be directly included. I imagine lelogger.php was added to ease setting up the LeLogger object, but it may be better to do this in the form of a factory method that takes an array for setup.

Just a thought.

Hi!

Would it be possible to add this library to packagist? I use composer for dependency management and would like to try out logentries, downloading files and adding them to the project root is a tad archaic though :-)

http://getcomposer.org/

Thanks,