lobophf / aimt Goto Github PK

Existing tests can be improved because I feel that there are many similar codes.. Perhaps the environment can be rewritten considering the test fixtures. Each test of the sub2ind and ind2sub functions could share the same information to decrease the code lines.

After rethinking about this project, I don't think that inventing conversions different from the traditional ones. I want to say that I must keep only the two main functions (sub2ind and ind2sub) and remove the other conversion functions.

After inserting macros in the aimt.h file, I forgot to update the comments. These are important for generating Doxygen files. However, working with macros requires additional settings. Soon I will to change the aimt.h file.

The tests that have already written cover only a few cases. That is, those where the user enters correct values ​​in the sub2ind and ind2sub functions. However, the code remains fragile because values ​​outside of ranges have not yet been considered. Therefore, the following list of unit tests is crucial.

• Add unit tests to sub2ind by predicting errors invoked by the inspectSubscripts function.
• Add unit tests to ind2sub by predicting errors invoked by the inspectIndex function.
• Add unit tests to prevent the index from being great than the maximum integer possible.

The sub2ind function can work with arrays of various dimensions that can certainly return an index value above the limit that an integer can support. Therefore, to prevent the integer overflow, it is necessary to change the sub2ind function so that it returns a long long int.

I made a mistake before regarding the integer overflow. The last element of the arrayOfDimensions must fit in the integer. In other words, I need to compute the maximum product of 9's. This document gave me ideas.

It would be nice if the error messages showed the document and the line where it occurred. I'll do this with macros.