Giter Club home page Giter Club logo

instantscore's Introduction

InstantScore

Server side of the InstantScore project

instantscore's People

Contributors

llaki avatar gkiko avatar

Stargazers

 avatar

Watchers

 avatar Kote Ujmajuridze avatar

instantscore's Issues

Save file in relative path

The file containing the data is saved without providing the directory path that should contain the file. The result is:
Linux: \usr\share\tomcat7\scores
Windows: D:\eclipse_enterprise\scores
The result is java.io.FileNotFoundException when running Linux code on Windows.
The code should be platform-independent.

IOException

My opinion: submitting user data causes IOException. Server code can't handle client requests.

scores writing... done writing TEST GETTING MATCH INFOS... scores CHANGES TO GOINT MATCHES BEING INVOKED... writing... IOException done writing scores scores IOException done writing TEST GETTING MATCH INFOS... scores CHANGES TO GOINT MATCHES BEING INVOKED... writing... writing... IOException done writing scores scores IOException done writing TEST GETTING MATCH INFOS... scores CHANGES TO GOINT MATCHES BEING INVOKED... writing...

Time conversion

Android users will get match list with their local time. Think the solution. Where should the time be converted: server or user side.

Lots of logs

We are having lots of non necessary logs. We can remove at least some of them, or log them into special file which gets cleared sometimes (for example, we can always delete the logs that have been generated 2 days ago).

The names of the classes

The names of some classes should not be changed, because in some cases the name doesn't really correspond to what the class is really responsible for.

Backup Data when Server Breaks

When server stops working, we should save the existing data somewhere. In current code, the users may have already chosen some matches, then the server has failed and on restart the previous data are lost. The users are still waiting for messages as they've registered, but they won't get anything. This scenario should be impossible.

As a solution, we might have a separate file where we save the necessary information. If the server breaks and then we restart it, we should be able to recover the data from that file.

The users are being copied all the time

In the current code, after each refresh of the livescore page, we copy all existing matches (together with their users, so it can be potentially a really large data). That can cause problems when we'll have a large amount of users.

Bug in case of penalties

If the match ends in penalties, we're missing the last message that notifies the final winner of the game.

Delete matches

User subscribed to match A. Later he sends data that does't contain match A. The user should be removed from the subscription list for math A.

Enable multiple users

Currently the code assumes only one user. The getPhoneNumber() method inside the user is "STUB" and always returns the same (my :) ) phone number. We should definitely change this later so that multiple users can use our service.

Bug if number not provided

com.twilio.sdk.TwilioRestException: The 'To' number +null is not a valid phone number.
at com.twilio.sdk.TwilioRestException.parseResponse(TwilioRestException.java:74)
at com.twilio.sdk.TwilioRestClient.safeRequest(TwilioRestClient.java:589)
at com.twilio.sdk.resource.list.MessageList.create(MessageList.java:70)
at twillio.Twilio.send(Twilio.java:44)
at securitycode.CodeGenerator.sendSecurityCodeToUser(CodeGenerator.java:36)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.