lkroner / phase_0_unit_2 Goto Github PK

Lauren -

you piqued my interest saying we had totally different solutions - so i wanted to check yours out.

inject is a super handy method to accumulate -
cool to to see you use it to solve both pieces of the challenge
I hope to put it into practice soon!

also - your sentence maker seems more efficient than mine - to convert the whole array to a string, and just capitalize the string, as opposed to iterating through each value then adding them up.
cool.

ok!
back to study -
Avi

Hey Lauren,
Your code looks really good. You've got a strong sense of what's going on, your pseudocode is excellent. Everything looks super solid to me. Great work!

Hi Lauren,

Great job on the Pez Dispenser Challenge. That challenge looks really fun, I ended up doing the playlist challenge instead. But looking at your code and someone else in my accountability group, the way the array is handle is totally different. It seems like your method is doing FIFO (First In First Out), while the other one I saw does FILO (First In Last Out). I guess its really subjective since an array isnt usually seen as a stack but as something from left to right. But either way its cool to see your code push (<<) elements into the pez container and use shift to remove, while the other code I saw uses unshift to push elements and pop to remove them.

I also like your assert statement on checking the count and all the flavors in the stack. I saw in your comment about why we are using assert instead of the plain driver code. I'm not positive but I think they are trying to slowly transition us to using rspec and assert might be a stepping stone. Also when I was first building the assert statement, I found this class in the Ruby doc.

http://ruby-doc.org/stdlib-2.0.0/libdoc/test/unit/rdoc/Test/Unit/Assertions.html

Maybe that has something to do with why we are starting to learn asserts.

Nice work!
Tony

Lauren,

This looks great! Your pseudocode and reflection are both very thorough, and your roll method is interesting. I hadn't thought of just calling sides from within roll - very clever!

I don't have too many suggestions for such a short challenge; I was going to suggest taking advantage of Ruby's implicit return, but I noticed that you already did this when you refactored. Well done!

Molly