ljhwang / prj-rev-bwfs-tea-cozy Goto Github PK

You ended this with a colon instead of a semi-colon so all your css from this line until the next semi colon merge and it was broken in this section.

This class name is just too generic, it is better to use more descriptive class names, something in the line of footer-text or footer-info would be much better for readability.

This should be avoided, did you try padding or margin top/bottom to create spacing?

If you have any sort of resolution scaling turned on in your computer settings this will throw everything off.

Color from the body will be inherited by some elements but not all elements. Usually just the default html text elements(headings, paragraph, etc) will inherit this.

Look at this screenshot from the dev tools you will see the color here was inherited from the body.

Overall met expectations.

Good organizational practices with commenting and html structure. CSS is very efficient. Good job on having matching comments to go back and forth between your html and css.

I didn't see any major errors or flaws that would warrant an issue. Bringing up Alt Text is more about best practices in web site creation.

To prepare you for the final projects, look at media queries. See if you can make this site fit inside of a mobile device by using one. You will be doing this heavily in your final projects.

https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries

https://www.w3schools.com/css/css3_mediaqueries_ex.asp

Start using alt text for your images

Nowadays, Web browsers are available in a very wide variety of platforms with very different capacities; some cannot display images at all or only a restricted set of type of images; some can be configured to not load images. If your code has the alt attribute set in its images, most of these browsers will display the description you gave instead of the images
some of your visitors cannot see images, be they blind, color-blind, low-sighted; the alt attribute is of great help for those people that can rely on it to have a good idea of what's on your page
search engine bots belong to the two above categories: if you want your website to be indexed as well as it deserves, use the alt attribute to make sure that they won't miss important sections of your pages