Giter Club home page Giter Club logo

Comments (3)

cyberj0g avatar cyberj0g commented on September 3, 2024

Addressed by: livepeer/FFmpeg@92c358e
AFAIK no changes to lpms are required.
Commited directly to the branch by accident, hope it's trivial enough to not mandate a PR in a secondary repo.

from lpms.

yondonfu avatar yondonfu commented on September 3, 2024

@cyberj0g Nice!

I see that livepeer/FFmpeg@92c358e updates ff_cuda_check() to return AVERROR(ENOMEM) if a CUDA_ERROR_OUT_OF_MEMORY is detected. Since LPMS only marks AVERROR_UNKNOWN as an unrecoverable error, with this change, LPMS will no longer mark CUDA OOM errors as unrecoverable.

In the future, it would be nice if there was a way to specifically signal the CUDA_ERROR_ILLEGAL_ADDRESS error from within ffmpeg since even with this change any other CUDA error besides CUDA_ERROR_OUT_OF_MEMORY would still get marked as unrecoverable since they all reach LPMS as AVERROR_UNKNOWN. The change in your commit as-is is still a useful improvement though!

from lpms.

Quintendos avatar Quintendos commented on September 3, 2024

Diederick working on this - dec' 22

from lpms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.