Giter Club home page Giter Club logo

Comments (4)

MikeIndiaAlpha avatar MikeIndiaAlpha commented on July 29, 2024

I did some testing and logging. Here is how the Profile changes during the configuration phrase when Nvidia encoder is active (no such problems on SW encoder)

0 :  {ERROR 1000k 30 0 854x480 16:9 0 3 0s 0 0 0}
0 :  {ERROR 1000k 30 0 480x853 16:9 0 3 0s 0 0 0}

Please note that not only width and height got swapped, also 854 changed to 853. I need to check in standard but AFAIR h.264 doesn't support odd cropping rectangles and so scaling/encoding may be going south on this one (showing green rectangle)

Notes: it looks like ensureEncoderLimits function may be reason for all this. Because:

  1. In Clamp method resolution is swapped if it is portrait, and...
  2. ...there are also floating point operations which may contribute to the dimensions being decreased by one due to rounding errors

from lpms.

cyberj0g avatar cyberj0g commented on July 29, 2024

Great find @MikeIndiaAlpha. Tagging @AlexKordic as he is the one who last worked on landscape-portrait and resolution clamping.

from lpms.

MikeIndiaAlpha avatar MikeIndiaAlpha commented on July 29, 2024

I spent some more time working on this and come up with the solution that I hope is not too disruptive: #354

from lpms.

Quintendos avatar Quintendos commented on July 29, 2024

Diederick working on this - dec' 22

from lpms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.