liugraphql / lingbm-optimizationtechniquesexperiments Goto Github PK

The resolver for undergraduateDegreeObtainedBystudent is incorrect, at least for the cache-variation of the test server.

Look at line 267 of src/cache/resolver/resolver.js. Here, the resolver applies the offset and the limit before applying the filter. That was not the intention. Instead, the filter has to be applied first.

The same problem may exist in the other server variations as well, and maybe also in other resolvers (I have not checked).

/cc @chengsijin0817

In addition to all the problems described in #1, the resolver for undergraduateDegreeObtainedBystudent in the cache-variation of the test server has another, even worse problem: The if-block for the filter condition creates a new variable called students by using the keyword let (see line 272), which makes this new variable not visible outside of this block!!! Consequently, after doing all of the filtering, the resolver completely ignores what it just did and, instead, returns the unfiltered list of grad students (see line 310)!!!!

Argh!!!