liubey / optimist Goto Github PK

Static method EntityWrapper.hasOptimisticLockingAnnotation is used but object 
being sent in is ever checked if it's null.

Should handle null in some way.

Move up trunk/optimist to trunk since gwt-optimist is moved to separate project.

Since I don't have spagettikod.com and groupId should reflect the actual domain 
of optimist, in this case, it would probably be a good idea to change the 
packages and groupId at this point.

Modify POM to generate a separate JavaDoc archive when packaging the project.

Current test cases are limited in support for more than one database type. 
Preferably the test cases should be the same but be "fed" with the correct 
connection and MyBatis mapping.

Move from JUnit to TestNG to support test suites using Maven2. The same tests 
need to be run but against different databases. 

It seems hard to run both optimist and gwt-optimist out of one Project Hosting 
project so I've create a separate project for gwt-optimist. Move source code 
there and move optimist back to root of trunk.

What steps will reproduce the problem?
1. suppose version in DB is 2
2. set version to value greater than 2, 20 for example
3. update success-ed and the version in DB changed to 21

What is the expected output? What do you see instead?
the update should be rejected, because the version does not match what in DB

What version of the product are you using? On what operating system?
all version

Please provide any additional information below.
the statement "return currentValueLong > thisVersion;" in 
EntityWrapper.isStale() should be changed to "return currentValueLong != 
thisVersion;"

Current only Integer and Long is supported as version types. There might be 
need to support Date.

It would make more sense to have the Mapper sub classes report back to the 
Mapper if the database is supported by a certain mapper.

When user issues a select-statement where ResultType-object is managed by 
Optimist it should detect if the object was removed by another user.

Releasing to Central require signing. See 
https://docs.sonatype.org/display/Repository/How+To+Generate+PGP+Signatures+With
+Maven

To comply with Maven2 central repository a -source.jar has to created when 
releasing.

What steps will reproduce the problem?
Call a method executing a DELETE, INSERT or UPDATE in the database without 
including a parameter.

What is the expected output? What do you see instead?
Expected output is a debug log saying something like "Optimist can not be 
used". Instead there is a NullPointerException.


Please use labels and text to provide additional information.

Since there is a log statement (that include the null object) before check for 
object being null a NPE might be thrown.

Both gwt-optimist and optimist point to trunk for SCM in the POM. Change these 
to point to their sub directories in trunk instead.

The following stacktrace occured. Reason unknown. Are we missing a 
try-statement?

Caused by: java.lang.NullPointerException
        at se.spagettikod.optimist.impl.EntityWrapper.isStale(EntityWrapper.java:237)
        at se.spagettikod.optimist.impl.OptimisticLockingInterceptor.updateImpl(OptimisticLockingInterceptor.java:81)
        at se.spagettikod.optimist.impl.OptimisticLockingInterceptor.intercept(OptimisticLockingInterceptor.java:139)
        at org.apache.ibatis.plugin.Plugin.invoke(Plugin.java:42)
        at $Proxy82.update(Unknown Source)
        at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:118)
        ... 65 more

Since the mapper issues an SELECT ... FOR UPDATE we need to catch any deadlock 
exceptions.

Add support for SQLite as database.