sync client and settimeout() about lua-websockets HOT 6 OPEN

After some debugging seems that sync.lua's receive()'s clean() is way too aggressive (why oh why?) in closing the connection on any kind of error. I added an if and it seems to work for me now:

  local clean = function(was_clean,code,reason)
    if reason ~= 'timeout' then
      self.state = 'CLOSED'
      self:sock_close()
      if self.on_close then
        self:on_close()
      end
    end
    return nil,nil,was_clean,code,reason or 'closed'
  end

PS. not sure if that won't cause problem if a timeout happens after the first sock_receive, when there is data in encoded and thus it will be lost?

from lua-websockets.

@EnTerr Added this as feature request. It's not that trivial, as you must think of partially received messages/frames.

from lua-websockets.

great. i'll keep this issue open, until ws:receive() accepts an optional timeout

from lua-websockets.

Ok, so here is a more complete fix i came up with, most code is round about https://github.com/lipp/lua-websockets/blob/master/src/websocket/sync.lua#L24

  ---
  if self._saved then
    local _ = self._saved
    first_opcode = _.first_opcode
    frames = _.frames
    bytes = _.bytes
    encoded = _.encoded
    self._saved = nil   -- erase the saved state
  end
  ---
  while true do
    local chunk, err, partial = self:sock_receive(bytes)

    if err then
      if err == 'timeout'  then
        if #partial > 0 then
          -- there was some partial data, update
          encoded = encoded .. partial
          bytes = bytes - #partial
        end
        -- save state for next call
        self._saved = {
          first_opcode = first_opcode, 
          frames = frames,
          bytes = bytes,
          encoded = encoded,
        }
      end
      return clean(false,1006,err)
    end

So every time receive() is called, it checks if there is a pending self._saved and if so restores state from it. Then on timeout error it saves partial data for the next time.

In addition, close() and connect() have to do self._saved = nil to ensure old state does not persist for potential next connection. And... that's it!

from lua-websockets.

nice! can you make a PR from this?

from lua-websockets.

Oops, afraid i can't. I don't have the code under git - besides i am working on almost a year old lua-websockets version, under svn. I did skim the /master/src/websocket/sync.lua here and there are no substantial/relevant changes - but i am nor really set up to PR. Maybe if one day i get current i will

from lua-websockets.