Giter Club home page Giter Club logo

lipas-api's People

Stargazers

avatar avatar avatar

Watchers

avatar avatar avatar

lipas-api's Issues

Missing routes from the Lipas REST API

Should all the same sports places that are visible on the Lipas map at https://www.lipas.fi/liikuntapaikat be also available through the REST API http://lipas.cc.jyu.fi/api?

I've come across quite a few trails especially that I can find on the map but can't get through the API.

Some examples:
Päijätsalon ulkoilureitti - 526047
Herajärven kierros - 600382
Raittijärven polku - 526471
Nuolivaaran luontopolku - 528638

If I try to get these with the "GET /sports-places/{sports-place-id}" request the response is 404.
Also trying to seach them with "GET /sports-places" and a searchString containing the name like http://lipas.cc.jyu.fi/api/sports-places?fields=name&searchString=Nuolivaaran doesn't produce any results.

Is this by design and if so are these and other items missing from this API available through some other API?

GET /sports-place-types responds with status 500

Currently calling the GET /sports-place-types method in API responds with HTTP 500.
This was still working fine just recently.

HTTP ERROR 500 java.lang.NullPointerException: Response map is nil
URI:	/api/sports-place-types
STATUS:	500
MESSAGE:	java.lang.NullPointerException: Response map is nil
SERVLET:	-
CAUSED BY:	java.lang.NullPointerException: Response map is nil
Caused by:

java.lang.NullPointerException: Response map is nil
	at ring.util.servlet$update_servlet_response.invokeStatic(servlet.clj:102)
	at ring.util.servlet$update_servlet_response.invoke(servlet.clj:93)
	at ring.util.servlet$update_servlet_response.invokeStatic(servlet.clj:97)
	at ring.util.servlet$update_servlet_response.invoke(servlet.clj:93)
	at ring.adapter.jetty$proxy_handler$fn__427.invoke(jetty.clj:28)
	at ring.adapter.jetty.proxy$org.eclipse.jetty.server.handler.AbstractHandler$ff19274a.handle(Unknown Source)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
	at org.eclipse.jetty.server.Server.handle(Server.java:516)
	at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388)
	at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
	at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
	at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:773)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:905)
	at java.base/java.lang.Thread.run(Thread.java:832)

List sports places implementation details

Could you provide some details on how the GET /api/sports-places method works.

When listing sports places with the closeTo parameters specified are the results returned in any specific order? Getting them sorted by distance to the requested point would make it easier to find out the closest N places with less additional requests needed. Of course sorting like might have some performance implications in the backend.

Also, how are sports places with LineString geometry types handled when listing with closeTo parameters? Is it based on the start, end, any or all points of the LineString being inside the requested radius to the closeTo point? For my use case I would prefer having these routes/linestrings returned when any of the points are within the radius. Best option could be to have a parameter to control this behavior: start/end/any.

GET /sports-place-types returning server error again

The GET /sports-place-types has broken down again and is returning 500. This seems the same as #2

Also the swagger.json is now showing the path of this method as /api//sports-place-types which does work normally.

Could be worth having even a simple set of automated tests for the API that are run after each deployment and nightly sync. Many of the recent issues would be quite easy to catch with such tests. Just an idea ;)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.