linux-on-ibm-z / pds Goto Github PK

On executing pytest in the test module, it runs on python2 environment by default.
Output of pytest :

===================== test session starts =====================
platform linux2 -- Python 2.7.18, pytest-4.6.9, py-1.8.1, pluggy-0.13.0
rootdir: /opt/PDS/src/tests
collected 0 items / 2 errors

This might lead to errors due to missing packages on systems having python3 as default installation.

Workaround : execute the command "sudo python3 -m pytest" to run on python3 environment.

PDS is written in Python 2.7, which reached it's End of Life back in January 2020, and pip will no longer have support for it coming up in January 2021, making the tool uninstallable at that point.

A migration to Python 3.8 should probably be investigated soon.

I was following the instructions for SLES 12, and when I get to the step instructing me to do "sudo pip install 'cryptography==1.4' Flask launchpadlib simplejson logging" the command ends with an error containing the following:

ERROR: Command errored out with exit status 1:
command: /usr/bin/python2 /usr/lib/python2.7/site-packages/pip-20.2.3-py2.7.egg/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpf3_NaV
cwd: /tmp/pip-install-BdET9I/httplib2
Complete output (4 lines):
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/pip-20.2.3-py2.7.egg/pip/_vendor/pep517/_in_process.py", line 15, in
from glob import glob
ImportError: No module named glob

ERROR: Command errored out with exit status 1: /usr/bin/python2 /usr/lib/python2.7/site-packages/pip-20.2.3-py2.7.egg/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpf3_NaV Check the logs for full command output.

I tried to remedy this, but Python 2.7 reached End of Life back in January, so the documentation for it is already starting to disappear and be supplanted by Python 3 documentation.

We're using the distro_data in the software-discovery-tool, and with PR #70, jsonlint is failing on all of the imported files. You can also see something is wrong if you simply open the files in a syntax-highlighting-aware editor.

It worked fine with #69 and prior:

elizabeth@naboo:~$ jsonlint RHEL_8_1_Package_List.json
RHEL_8_1_Package_List.json: ok

This is due to missing quotes in these JSON files in the newly committed PR, for example:

Working from #69: {"packageName":"bash", "version":"4.4.19-10.el8"},

Failing from #70: {packageName:bash, version:4.4.19-10.el8},

Also, maybe it would be valuable to add a json-lint GitHub Action to PRs moving forward so this doesn't happen again? There are a couple in the GitHub Actions Marketplace, but I haven't evaluated them.