Giter Club home page Giter Club logo

cpp-code-challenges-3096958's Issues

Minor bug in ch8_ip_address.cpp

Issue Overview

Minor bug parsing IP Addresses in ch8_ip_address.cpp

Describe your environment

The following line incorrectly includes square brackets in the character set:

    21	    if(str.find_first_not_of("[0123456789]") == std::string::npos)

Steps to Reproduce

  1. [1].2.3.4 throws an exception due to stoi("[1]")
  2. 1].2.3.4 gives a false positive due to stoi("1]") succeeding with returning 1.

Expected Behavior

[1].2.3.4 and 1].2.3.4 should both fail gracefully.

Current Behavior

$ ./a.out

Enter an IP address in decimal: [1].2.3.4
 
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted
$ ./a.out

Enter an IP address in decimal: 1].2.3.4
 
1].2.3.4 is a valid IP address.

Possible Solution

Remove square brackets, and it works.

$ ./a.out

Enter an IP address in decimal: [1].2.3.4
 
[1].2.3.4 is not a valid IP address.
$ ./a.out

Enter an IP address in decimal: 1].2.3.4
 
1].2.3.4 is not a valid IP address.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.