lin777 / enjoliveur Goto Github PK

• better extract method with argument: the best thing would be let the user specify the argument

installStableVersionButton: aList
	<menu>
	aList
		act: [ :presenter | self onInstallFrom: presenter ]
		icon: (Smalltalk ui icons iconNamed: #glamorousAccept)
		entitled: 'Install stable version'

=> now is just producing

installStableVersionButton: aList
	<menu>
	aList
		act: [ :presenter | self onInstallFrom: presenter ]
		icon: self iconNamed
		entitled: 'Install stable version'

iconNamed
	(Smalltalk ui icons iconNamed: #glamorousAccept)

and we want to have

installStableVersionButton: aList
	<menu>
	aList
		act: [ :presenter | self onInstallFrom: presenter ]
		icon: (self iconNamed: #glamorousAccept)
		entitled: 'Install stable version'
		
iconNamed: aSymbol
	(Smalltalk ui icons iconNamed: aSymbol)

Extract refactorings should be easily accessible with a common shortcut pattern to use them

• Extract Constant, https://www.jetbrains.com/help/idea/extract-constant.html
• Extract Field, https://www.jetbrains.com/help/idea/extract-field.html
• Extract method, https://www.jetbrains.com/help/idea/extract-method.html
• Extract Superclass, https://www.jetbrains.com/help/idea/extract-superclass.html
• Extract Variable, https://www.jetbrains.com/help/idea/extract-variable.html
• Extract parameter, https://www.jetbrains.com/help/idea/javaintroduce.html
• Extract into class refactorings, https://www.jetbrains.com/help/idea/extract-into-class-refactorings.html

We should have a preview dialog allowing to choose what to apply.
We should have tests, including for shortcuts activation

If I want to remove a class A and a class B with B referencing A, currently, Calypso will warn me that A is still referenced before applying the refactoring.

IMO this should not happen because the class referencing A is part of the classes to remove.

cf https://www.jetbrains.com/help/idea/invert-boolean-refactoring.html

pharo-project/pharo#3355

In the past refactorings could undone and I do not see how this is possible.

Right now checkMethodName: aName in: aClass is defined as

checkMethodName: aString in: aClass
"Return whether the argument aString is can represent a selector"
"You probably look for checkMethodName: since the second argument is ignored"

^ aString isString and: [ RBScanner isSelector: aString ]

and this is a bit suspicious not to use the second argument.

We should have consistent shortcuts for most used refactorings:

• all extract refactorings
• in line
• invert condition
• push up / pull down
• rename / move
  etc.

and their new environment variable could be initialized to Smalltalk globals for now.

pharo-project/pharo#3175

Hi evelyn can you have a look at this issue?

Sometimes I want to rename a method without renaming all the other implementors and senders
I can do it by editing the method but I have not to forget to remove the previous one.
So this is probably not related to the refactoring but this is a simple operation that we could introduce.

cf https://www.jetbrains.com/help/idea/find-and-replace-code-duplicates.html

It looks like the symptoms of a refactoring raising a pop up.

Not all the refactorings are available as Refactoring2
We should convert them and avoid to have duplication.

pharo-project/pharo#3176

pharo-project/pharo#2146

pharo-project/pharo#4198

Hi

I had
root
subone
subtwo

and I remove subone.
and the systeme told me that there subclasses and opened an empty list :(

extract method :)

see pharo-project/pharo#2939

SycMethodNameEditor is already made using spec in https://github.com/CafeKrem/stage

May be we have it.

But how to replace one method call by another one

for example we have two methods
atX: x atY: y
and
atRow: rowNumber atColumn: columnNumber
and we want all methods to use atRow:atColumn:

Some conditions have arcane explanations.
We should revisit them.

cf https://www.jetbrains.com/help/idea/inline.html

This refactoring already exists (inline method and inline temporary)

checkMethodName: aName in: aClass
^aName isString and: [RBScanner isSelector: aName]

did not use aClass

so introduce

checkMethodName: aName
^aName isString and: [RBScanner isSelector: aName]

May be into InteractiveRefactoring

I often would like to extract a class reference into a method and then apply this to a complete hierarchy.

introduce self parserClass and use it instead.

I wanted to rename a method and the browser prompted me that I will rename two implementations. I had to cancel. :(

Imagine that I have a method foo ^ 33
when I extract 33 as foo the system should that the body is the same and it should not tell me that I may change the behavior.

I get a warning telling that the code is duplicated but the rules could ask me to remove it.
Also doing a push up ask me if I want to push down the method above in the other subclasses - this makes a lot of sense but when I say no it would be good to push up the method = remove it locally.

pharo-project/pharo#4194